Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider improving option description for ENABLE_WEB #4755

Closed
jpalus opened this issue Feb 8, 2023 · 1 comment · Fixed by #4760
Closed

Consider improving option description for ENABLE_WEB #4755

jpalus opened this issue Feb 8, 2023 · 1 comment · Fixed by #4760
Assignees
@ckerr
Labels
confirmed type:build Changes that affect the build system

Comments

@jpalus
Copy link

jpalus commented Feb 8, 2023

What is the issue?

Looking at CMakeLists.txt:

transmission/CMakeLists.txt

Lines 46 to 49 in 6576a2a

tr_auto_option(ENABLE_GTK "Build GTK client" AUTO)
tr_auto_option(ENABLE_QT "Build Qt client" AUTO)
tr_auto_option(ENABLE_MAC "Build Mac client" AUTO)
tr_auto_option(ENABLE_WEB "Build Web client" AUTO)

You can see options for toggling GTK/QT/WEB clients. It may appear for all of them that they either disable or enable functionality completely which is not the case for ENABLE_WEB. What it really appears to mean is something along regenerate web artifacts with npm (uses network). It's somewhat confusing as even with -DENABLE_WEB=OFF web client is installed, just with artifacts shipped with git/release tarball. It would be really good if option name and description could better reflect that.

Which application of Transmission?

None

Which version of Transmission?

4.0.0
@ckerr ckerr self-assigned this Feb 8, 2023
@ckerr ckerr added confirmed type:build Changes that affect the build system labels Feb 8, 2023
@ckerr
Copy link
Member

ckerr commented Feb 8, 2023

Yep, this is a leftover from #4658, which has a decent writeup of why transmission-web is built the way it is.

To be clear in case other builders / packagers are reading this -- this isn't a bug in the 4.0.0 cmake with transmission-web, things will still build right.

But @jpalus is right it is very confusing and the terminology should be something like he described above.

pld-gitsync pushed a commit to pld-linux/transmission that referenced this issue Feb 8, 2023
@jpalus
up to 4.0.0
058ef47 
- disable werror within shipped libutp and prevent use of (future)
  system libutp (transmission requires its own customized libutp)
  see transmission/transmission#4748
- ENABLE_WEB disabled since it does not do what it seems to do
  see transmission/transmission#4755
@ckerr ckerr mentioned this issue Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckerr ckerr

Labels
confirmed type:build Changes that affect the build system
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: renamed ENABLE_WEB build option for clarity transmission/transmission
2 participants
@ckerr @jpalus