Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: renamed ENABLE_WEB build option for clarity #4760

Merged
merged 1 commit into from
Feb 8, 2023
Merged

build: renamed ENABLE_WEB build option for clarity #4760

merged 1 commit into from
Feb 8, 2023

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Feb 8, 2023

Fixes #4755.

@ckerr ckerr added type:build Changes that affect the build system notes:none Should not be listed in release notes labels Feb 8, 2023
@ckerr ckerr added this to the 4.0.1 milestone Feb 8, 2023
@ckerr
Copy link
Member Author

ckerr commented Feb 8, 2023

Failed to publish build.finish.properties.gz file. No space left on device

CI failure is unrelated to PR

@ckerr ckerr merged commit 7a686a5 into main Feb 8, 2023
@ckerr ckerr deleted the build/rename-cmake-ENABLE_WEB-option-for-clarity branch February 8, 2023 23:47
ckerr added a commit that referenced this pull request Feb 11, 2023
@ckerr
Revert "build: renamed ENABLE_WEB build option for clarity (#4760)"
a81af8d 
This reverts commit 7a686a5.
@ckerr ckerr mentioned this pull request Feb 13, 2023
Closed
@tearfur tearfur mentioned this pull request Jul 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
notes:none Should not be listed in release notes type:build Changes that affect the build system
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.

Consider improving option description for ENABLE_WEB
1 participant
@ckerr