Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color well of groups is cut at the top #5011

Closed
decodism opened this issue Feb 23, 2023 · 4 comments · Fixed by #5016
Closed

Color well of groups is cut at the top #5011

decodism opened this issue Feb 23, 2023 · 4 comments · Fixed by #5016
Labels
good first issue For people who'd like to start contributing pr welcome scope:mac type:ui

Comments

@decodism
Copy link

What is the issue?

There is also a gray border on the inside.

transmission_2

Which application of Transmission?

macOS app

Which version of Transmission?

4.0.1
@ckerr ckerr added pr welcome good first issue For people who'd like to start contributing needs UI review This PRs has UI changes that need review type:ui scope:mac labels Feb 23, 2023
@nevack
Copy link
Member

nevack commented Feb 23, 2023

It's how Cocoa UI renders it, I don't see how this can be fixed.

But we can change style to more modern one at least for 13.0+
https://developer.apple.com/videos/play/wwdc2022/10074/?time=441

image

@decodism
Copy link
Author

The gray border seems to be due to a bad color space. Maybe use sRGB?

@nevack
Copy link
Member

nevack commented Feb 23, 2023

The gray border seems to be due to a bad color space. Maybe use sRGB?

I think this is a wrong guess, we use default colors and do not customise this control, so this should work out of the box.

nevack added a commit to nevack/transmission that referenced this issue Feb 23, 2023
@nevack
feat: Use updated minimal NSColorWell style for Groups.
cad2ed0 
Only on macOS Ventura (13.0+), as AppKit changes were introduced here.

Somewhat fixes transmission#5011

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
@nevack nevack mentioned this issue Feb 23, 2023
Merged
@decodism
Copy link
Author

decodism commented Feb 23, 2023 •
edited

Updating the color through the control fixes the problem. It is likely linked to the default colors.

nevack added a commit to nevack/transmission that referenced this issue Feb 23, 2023
@nevack
feat: Use updated minimal NSColorWell style for Groups.
4113721 
Only on macOS Ventura (13.0+), as AppKit changes were introduced here.

Somewhat fixes transmission#5011

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
@Coeur Coeur removed the needs UI review This PRs has UI changes that need review label Feb 25, 2023
ckerr pushed a commit to nevack/transmission that referenced this issue Feb 25, 2023
@nevack @ckerr
feat: Use updated minimal NSColorWell style for Groups.
37ce933 
Only on macOS Ventura (13.0+), as AppKit changes were introduced here.

Somewhat fixes transmission#5011

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
ckerr pushed a commit to nevack/transmission that referenced this issue Feb 26, 2023
@nevack @ckerr
feat: Use updated minimal NSColorWell style for Groups.
122a73d 
Only on macOS Ventura (13.0+), as AppKit changes were introduced here.

Somewhat fixes transmission#5011

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
ckerr pushed a commit that referenced this issue Feb 27, 2023
@nevack
feat: Use updated minimal NSColorWell style for Groups. (#5016)
4430f72 
* feat: Use updated minimal NSColorWell style for Groups.

Only on macOS Ventura (13.0+), as AppKit changes were introduced here.

Somewhat fixes #5011

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For people who'd like to start contributing pr welcome scope:mac type:ui
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Use updated minimal NSColorWell style for Groups. nevack/transmission
4 participants
@ckerr @Coeur @nevack @decodism