feat: Use updated minimal NSColorWell style for Groups. #5016
Conversation
|
@nevack thanks for the before after. 👍 UI LGTM |
|
@nevack needs a whitespace change to make the linter happy: https://github.com/transmission/transmission/actions/runs/4257356667/jobs/7407395917 |
nevack
force-pushed
the
nevack/updated-nscolorwell-style
branch
from
cad2ed0
to
4113721
Compare
Done, thanks |
|
Oof, we use Xcode 13.x on CI, so no macOS 13 SDK available :( |
|
looks like we could bump it to a macOS 12 runner. Try a global replace of |
There are some other concerns. |
nevack
force-pushed
the
nevack/updated-nscolorwell-style
branch
from
18ab5ab
to
fef0245
Compare
|
Code looks good. Let me check if it builds properly on older Xcode tomorrow. |
|
UI-wise: there is no regression in functionality, as there is a button to access the whole color wheel. So it's good. |
|
To repeat a question from another ticket: is this a bugfix or a new feature? Asking because the code looks like a fix and the description says "somewhat fixes", but the title describes it as a feature, so I'm wondering if there's some aspect I'm missing. |
ckerr
force-pushed
the
nevack/updated-nscolorwell-style
branch
from
fef0245
to
04b5c8b
Compare
|
It's a UI fix. Doesn't offer extra functionality. Good to merge as patch. |
Only on macOS Ventura (13.0+), as AppKit changes were introduced here. Somewhat fixes transmission#5011 Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
This APIs are available only with Xcode 14.1 or later. Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
ckerr
force-pushed
the
nevack/updated-nscolorwell-style
branch
from
04b5c8b
to
631ebf6
Compare
|
Notes: Fixed minor UI bugs, e.g. layout and control alignment. |
Only on macOS Ventura (13.0+), as AppKit changes were introduced here.
Somewhat fixes #5011
Comparison