Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make mac icons a consistent size #3103

Closed
wants to merge 8 commits into from

Conversation

GaryElshaw
Copy link
Contributor

Hopefully fixes #3100

@Coeur
Copy link
Collaborator

Coeur commented May 16, 2022

Thanks. But can you keep it 18x18px and 36x36px?
Both buttons and both images are sized to be 18x18px (the other image is TurtleTemplate).
Capture d’écran 2022-05-17 à 04 03 28

@GaryElshaw
Copy link
Contributor Author

GaryElshaw commented May 17, 2022

Thanks. But can you keep it 18x18px and 36x36px? Both buttons and both images are sized to be 18x18px (the other image is TurtleTemplate). Capture d’écran 2022-05-17 à 04 03 28

It sucks, but Unfortunately the problem is the height. The only other option would be to increase the height of the bar?

Edit: Something's up with those XCode values Antoine, 18 is not the value of the the original image. https://github.com/transmission/transmission/pull/3103/files
Here's how it looks from the TC build:
SCR-20220517-jv4

@Oleg-Chashko
Copy link
Contributor

Please, make the turtle a little bigger. Take the size of the pinion as the base size. Thanks.

@GaryElshaw
Copy link
Contributor Author

Please, make the turtle a little bigger. Take the size of the pinion as the base size. Thanks.

They all have very unique profiles - essentially a circle, a rectangle, and a pyramid. The danger in adapting them further is that they look even less uniform than they currently do. As it stands, each of these are at different sizes and I don't think they'll tolerate more resizing without adjusting the lower bar.

@Oleg-Chashko
Copy link
Contributor

Oleg-Chashko commented May 17, 2022

It 18x18px and 36x36px.
Source - Sketch_App & etc.zip

Center alignment Example:

  • CleanupTemplate - Example:

CleanupTemplate - Example

  • CleanupTemplate@2x - Example:

CleanupTemplate@2x - Example

@ckerr ckerr requested a review from Coeur May 17, 2022 14:45
@GaryElshaw
Copy link
Contributor Author

I am aware of that Oleg. You pointed out that the height of the icon was not consistent in #3100, and it's why i decreased the size of that particular icon so it would be commensurate with the height margin you illustrated.

Is that not the case? I'm sorry, i don't understand what you are trying to say.

@Oleg-Chashko
Copy link
Contributor

Bottom alignment Example:

Use the icons from the archive. There should be a positive result.

Archive.zip

Screen Shot 2022-05-17 at 16 53 11

@GaryElshaw
Copy link
Contributor Author

Bottom alignment Example:

Use the icons from the archive. There should be a positive result.

Archive.zip

Screen Shot 2022-05-17 at 16 53 11

Now i'm even more confused. Those images are the original ones i edited and reduced from 36x36 to 32x32. https://github.com/transmission/transmission/pull/3103/files

@Oleg-Chashko
Copy link
Contributor

I am aware of that Oleg. You pointed out that the height of the icon was not consistent in #3100, and it's why i decreased the size of that particular icon so it would be commensurate with the height margin you illustrated.

Is that not the case? I'm sorry, i don't understand what you are trying to say.

That's right and it's just like you say. I redid the icons. And that's why I'm asking you to check it out.
And gave you the source so you can change it however you want.

@Oleg-Chashko
Copy link
Contributor

I apologize for not writing this to you right away.

Icon (canvas) size remains 36x36 but drawing size is now 32x32
Icon (canvas) size remains 18x18 but drawing size is now 16x16

@GaryElshaw
Copy link
Contributor Author

That's fine, thanks for letting me know!

@GaryElshaw
Copy link
Contributor Author

@Coeur @sweetppro I just noticed this in the MainMenu.xib. I wonder why that default drop-down icon on the far left was never implemented?

SCR-20220518-r8k

Currently playing around with the recycling icon because we don't recycle, we literally trash :-(

CleanupTemplate copy

@sweetppro
Copy link
Collaborator

The trash icon indicates deleting the Torrent. But we are actually removing it from the interface.

i personally think the recycle icon, while maybe not perfect - is better than a trash can

@GaryElshaw
Copy link
Contributor Author

@Coeur ping

@mangosplat
Copy link

mangosplat commented May 19, 2022

@GaryElshaw you haven't changed it to the downsized* icons @Oleg-Chashko has created

@GaryElshaw
Copy link
Contributor Author

@GaryElshaw you haven't changed it to the downsized* icons @Oleg-Chashko has created

Because #3113 will rebase the changes and make Oleg's request and this PR moot. @sweetppro

@ckerr ckerr changed the title CleanupTemplate-imageset make mac icons a consistent size May 20, 2022
@GaryElshaw
Copy link
Contributor Author

Superseded by #3113

@GaryElshaw GaryElshaw closed this May 27, 2022
@GaryElshaw GaryElshaw deleted the cleanup-template branch May 27, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

macOS, v.3.00+, Icons should preferably be the same size
6 participants