-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make mac icons a consistent size #3103
Conversation
02ec7aa
to
4d4ba79
Compare
It sucks, but Unfortunately the problem is the height. The only other option would be to increase the height of the bar? Edit: Something's up with those XCode values Antoine, 18 is not the value of the the original image. https://github.com/transmission/transmission/pull/3103/files |
Please, make the turtle a little bigger. Take the size of the pinion as the base size. Thanks. |
They all have very unique profiles - essentially a circle, a rectangle, and a pyramid. The danger in adapting them further is that they look even less uniform than they currently do. As it stands, each of these are at different sizes and I don't think they'll tolerate more resizing without adjusting the lower bar. |
It 18x18px and 36x36px. Center alignment Example:
|
I am aware of that Oleg. You pointed out that the height of the icon was not consistent in #3100, and it's why i decreased the size of that particular icon so it would be commensurate with the height margin you illustrated. Is that not the case? I'm sorry, i don't understand what you are trying to say. |
Bottom alignment Example: Use the icons from the archive. There should be a positive result. |
Now i'm even more confused. Those images are the original ones i edited and reduced from 36x36 to 32x32. https://github.com/transmission/transmission/pull/3103/files |
That's right and it's just like you say. I redid the icons. And that's why I'm asking you to check it out. |
I apologize for not writing this to you right away. Icon (canvas) size remains 36x36 but drawing size is now 32x32 |
That's fine, thanks for letting me know! |
@Coeur @sweetppro I just noticed this in the MainMenu.xib. I wonder why that default drop-down icon on the far left was never implemented? Currently playing around with the recycling icon because we don't recycle, we literally trash :-( |
The trash icon indicates deleting the Torrent. But we are actually removing it from the interface. i personally think the recycle icon, while maybe not perfect - is better than a trash can |
@Coeur ping |
@GaryElshaw you haven't changed it to the downsized* icons @Oleg-Chashko has created |
Because #3113 will rebase the changes and make Oleg's request and this PR moot. @sweetppro |
Superseded by #3113 |
Hopefully fixes #3100