New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix macOS statusBar icons #3113
fix macOS statusBar icons #3113
Conversation
make macOS status icons consistent accross all versions of macOS
We have conflicting PR's :-( #3114 |
@sweetppro and @GaryElshaw can the two of you figure out which PR should be used? 🙂 |
@ckerr, @sweetppro's then mine. |
@ckerr They both do different things. mine fixes the icon sizes and makes them consistent across macOS versions. |
@Coeur ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTBFS
CMake Error at macosx/CMakeLists.txt:423 (add_executable):
19:10:31 Cannot find source file:
19:10:31
19:10:31 Images/Images.xcassets/TurtleTemplate.imageset/TurtleTemplate.png
19:10:31
19:10:31 Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
19:10:31 .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
19:10:31
19:10:31
19:10:31 CMake Error at macosx/CMakeLists.txt:423 (add_executable):
[19:10:31 ](https://trtc.mikedld.com/buildConfiguration/Transmission_Sanity_MacOSX8664/213420?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandchucktcpluginBuild=false&expandBuildProblemsSection=true&showLog=213420_598_598&logView=flowAware) No SOURCES given to target: transmission-mac
…etppro/transmission into macOS-statusBar-icon-cleanup
@ckerr this is now fixed |
@sweetppro Something has happened to the tortoise's head :-( |
It is highly irregular that you removed someone else from the AUTHORS file. You could have removed the Tortoise comment to make it clear that the current Tortoise is not created by Dean Ostetto, but he still deserves to be credited for his contribution. |
make macOS status icons consistent across all versions of macOS
#3103 #3100 #3112