Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new information about when torrent was added to transmission in the Information Tab in transmission-qt #3121

Merged
merged 3 commits into from May 23, 2022
Merged

Add new information about when torrent was added to transmission in the Information Tab in transmission-qt #3121

merged 3 commits into from May 23, 2022

Conversation

sewe2000
Copy link
Contributor

@sewe2000 sewe2000 commented May 22, 2022 •
edited

Resolves #1729 in qt version.

ile6695
ile6695 reviewed May 22, 2022
View reviewed changes
Copy link
Contributor

@ile6695 ile6695 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds as expected and looks good. There's one extra newline character in qt/DetailsDialog.ui

qt/DetailsDialog.ui Outdated Show resolved Hide resolved
@sewe2000
Remove additional newline character
f27dddc 
... in DetailsDialog.ui
ile6695
ile6695 approved these changes May 22, 2022
View reviewed changes
Copy link
Contributor

@ile6695 ile6695 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ckerr
ckerr approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ckerr ckerr merged commit 4617776 into transmission:main May 23, 2022
ckerr added a commit that referenced this pull request May 23, 2022
@ckerr
Squashed commit of the following:
6d072d0 
commit 4617776
Author: sewe2000 <59435262+sewe2000@users.noreply.github.com>
Date:   Mon May 23 05:02:46 2022 +0000

    Add new information about when torrent was added to transmission in the Information Tab in transmission-qt (#3121)

commit 67a0784
Author: Charles Kerr <charles@charleskerr.com>
Date:   Sun May 22 21:22:34 2022 -0500

    fix: compiler warnings (#3123)

    * fix: unused function warning tr_rpc_address_is_valid

    * fix: unused variable warning old_byte_pop

    * fix: method-can-be-made-static warning assertValidRules

    * fix: signed-unsigned comparison warning

    * fix: invalid case style warning for KBps

    * chore: disable warning for static class member varaible
@rybak
Copy link

rybak commented May 23, 2022

@sewe2000 thank you for working on this. Thanks to @ile6695 for review. And thank you, @ckerr, for maintaining Transmission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@ile6695 ile6695 ile6695 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Show when a torrent was added in "Torrent Properties" window
4 participants
@sewe2000 @rybak @ckerr @ile6695