fix: compiler warnings #3123
Merged
fix: compiler warnings #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added a commit
that referenced
this pull request
May 23, 2022
commit 67a0784 Author: Charles Kerr <charles@charleskerr.com> Date: Sun May 22 21:22:34 2022 -0500 fix: compiler warnings (#3123) * fix: unused function warning tr_rpc_address_is_valid * fix: unused variable warning old_byte_pop * fix: method-can-be-made-static warning assertValidRules * fix: signed-unsigned comparison warning * fix: invalid case style warning for KBps * chore: disable warning for static class member varaible
ckerr
added a commit
that referenced
this pull request
May 23, 2022
commit 4617776 Author: sewe2000 <59435262+sewe2000@users.noreply.github.com> Date: Mon May 23 05:02:46 2022 +0000 Add new information about when torrent was added to transmission in the Information Tab in transmission-qt (#3121) commit 67a0784 Author: Charles Kerr <charles@charleskerr.com> Date: Sun May 22 21:22:34 2022 -0500 fix: compiler warnings (#3123) * fix: unused function warning tr_rpc_address_is_valid * fix: unused variable warning old_byte_pop * fix: method-can-be-made-static warning assertValidRules * fix: signed-unsigned comparison warning * fix: invalid case style warning for KBps * chore: disable warning for static class member varaible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a handful of minor compiler warnings that had snuck into the codebase over the last month or so.