Fix "NSFilenamesPboardType is deprecated" #4221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevack
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
LGTM
@Coeur I kindly ask you to split changes like this in the future.
Maybe not separate PRs, but commits will do.
Most of this PR are typing improvements that are not related to the fix.
It will be easier to review commit by commit.
Thanks!
|
OK for multi commits next time. Here it was to highlights that, while |
ckerr
force-pushed
the
coeur/NSPasteboardType
branch
2 times, most recently
from
47bc1cb
to
057a1e7
Compare
Coeur
force-pushed
the
coeur/NSPasteboardType
branch
from
057a1e7
to
1f7403a
Compare
|
Notes: Fixed macOS API deprecation warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another deprecation biting the dust.
This time, NSFilenamesPboardType and NSURLPboardType.
I tested the change is non-breaking by drag&dropping files and urls.