build: fix libdeflate find module never finding anything #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mikedld
force-pushed
the
bugfix/deflate-find-module
branch
from
6e17886
to
75688ec
Compare
`DEFLATE_VERSION` was never set but was listed as required. Move it from `REQUIRED_VARS` to `VERSION_VAR` and populate properly.
ckerr
force-pushed
the
bugfix/deflate-find-module
branch
from
75688ec
to
f0fb2ad
Compare
ckerr
changed the title
|
FreeBSD build on TeamCity finally found it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFLATE_VERSIONwas never set but was listed as required. Move it fromREQUIRED_VARStoVERSION_VARand populate properly.Notes: Fixed build issue that prevented preinstalled copies of libdeflate from being used