Add test about name parameter

transmute-industries · Jul 24, 2018 · a50a55c · a50a55c
1 parent 2d63dc6
commit a50a55c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/contracts/JobManager.sol b/contracts/JobManager.sol
@@ -38,7 +38,6 @@ contract JobManager {
   mapping(uint => Job) public jobs;
 
   function submitMineral(string _name, uint _category) external {
-    // TODO name must be non null
     // Mineral has to be one of two categories: Compute or Storage
     MineralCategory mc;
     if(_category == uint(MineralCategory.Compute)) {

diff --git a/test/JobManager.spec.js b/test/JobManager.spec.js
@@ -48,6 +48,14 @@ contract('JobManager', accounts => {
         }
       });
     });
+
+    it('should accept no name for Mineral', async () => {
+      const mineralId = (await jm.numberOfMinerals.call()).toNumber();
+      await jm.submitMineral("", MINERAL_COMPUTE);
+      const mineral = await jm.minerals.call(mineralId);
+      let [name, _] = mineral;
+      assert.equal("", name);
+    });
   });
 
   describe('job', () => {