Branch coverage support for JaCoCo #108
Conversation
Now the line range is verified before adding the branch. The logic that verifies line boundary was extracted to method checkLineRange(int).
|
|
||
| // add branches. unfortunately, there is NO block number and | ||
| // branch number will NOT be unique between coverage changes. | ||
| int branchId = 0; |
There was a problem hiding this comment.
Probably is better to use an unique ID per source file or session instead of an unique ID per condition.
|
Thanks for contributing this! I'm using this patch in my fork right now. Question: to what extent is it conventional in Coveralls to identify branches by an index? Is a message like "Branches [[0, 14], [0, 15]] missed" the standard for all languages? |
|
@trautonen could you please merge this work and publish a new version? It's a pity that such a great PR is not merged for two years already. Thanks. |
|
Wow merged 6 years later, is this still working ? If you guys need any help on this feel free to mention me :) |
|
Ive been using it 🤷🏻♂️ |
|
Unfortunately, I still have no way to make the upgrade versions and push to Maven repo. I have no credentials and tooling for that. I'm wondering to create a new account there.. for the continuity of this project. |
|
I've been facing the same issue after taking over Querydsl 🤣 |
You can follow the descriptions in the git commit history 😄