Use new API endpoint to validate token #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new endpoint https://developer.github.com/v3/apps/oauth_applications/#check-a-token replaces https://developer.github.com/v3/apps/oauth_applications/#check-an-authorization https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/ https://developer.github.com/changes/2020-02-14-deprecating-oauth-app-endpoint/
BanzaiMan
commented
Mar 31, 2020
| error = GH::Error.new | ||
| error.info[:response_status] = 500 | ||
| raise error | ||
| end | ||
| expect { subject['/x'] }.not_to raise_error | ||
| expect { subject['/x'] }.to raise_error(GH::Error(:response_status => 500)) |
There was a problem hiding this comment.
It seems to me that the previous spec, while pending, was wrong.
`GH::Remote` should be able to pass body to HTTP backend.
Changing `#http` call signature
(`def http(verb, url, body, headers = {}, &block)`) may be a little
risky, so we piggyback on `headers`.
Tested with pry[1] pry(main)> require 'gh'
=> true
[2] pry(main)> token_check=GH::TokenCheck.new
=> #>
[3] pry(main)> token_check.client_id = 'XXX'
=> "XXX"
[4] pry(main)> token_check.client_secret = 'YYY'
=> "YYY"
[6] pry(main)> token_check.token = 'ZZZ'
=> "ZZZ"
[7] pry(main)> token_check.check_token
=> #<Faraday::Response:0x00007fc16cac7c60
@env=
#<struct Faraday::Env
method=:post,
body=
"{\"id\":AAAAA,\"url\":\"https://api.github.com/authorizations/AAAAA\",\"app\":{\"name\":\"Travis staging\",\"url\":\"https://staging.travis-ci.org\",\"client_id\":\"XXX\"},\"token\":\"ZZZ\",\"hashed_token\":\"BBBBB\",\"token_last_eight\":…
|
|
I've also checked the use of this new call with travis.rb locally. |
BanzaiMan
commented
Apr 6, 2020
| @@ -75,7 +75,8 @@ def generate_response(key, response) | |||
|
|
|||
| # Internal: ... | |||
| def http(verb, url, headers = {}, &block) | |||
| connection.run_request(verb, url, nil, headers, &block) | |||
| body = headers.delete :body | |||
There was a problem hiding this comment.
This is somewhat iffy; ideally, we would be changing the call signature of #http, so that body is set properly without really hacking into headers parameter.
pavel-d
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new endpoint
https://developer.github.com/v3/apps/oauth_applications/#check-a-token
replaces
https://developer.github.com/v3/apps/oauth_applications/#check-an-authorization
https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/
https://developer.github.com/changes/2020-02-14-deprecating-oauth-app-endpoint/