Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link against oniguruma statically #36

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Apr 11, 2019

No description provided.

@nikic nikic force-pushed the oniguruma branch 3 times, most recently from c4be26d to 5672906 Compare April 11, 2019 08:17
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Apr 11, 2019
* Move snapshot tests to a separate stage to always have them run last, regardless of other stages
* Install libonig-dev as it is temporarily required for snapshot and nighly tests (see travis-ci/php-src-builder#36)
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Apr 11, 2019
* Install libonig-dev as it is temporarily required for snapshot and nighly tests (see travis-ci/php-src-builder#36)
@ostrolucky
Copy link

@BanzaiMan seeing you helped merge #31, can you take a look here as well, please? People are avoiding testing PHP 7.4 snapshots because of this

@nikic
Copy link
Contributor Author

nikic commented Apr 25, 2019

Ping

@sebastianbergmann
Copy link

Thank you, @BanzaiMan. How often is PHP master updated on Travis? I don't think it's actually "nightly".

@nikic
Copy link
Contributor Author

nikic commented Apr 28, 2019

@sebastianbergmann The build does happen every day, see https://travis-ci.org/travis-ci/php-src-builder/builds -- it just doesn't always succeed. If there are upstream changes in the build system (of which there are a lot in 7.4) then Travis may fail to produce new snapshot builds for a while, until the issue is resolved.

This change should've gone out already though. Are you still seeing issues?

sebastianbergmann added a commit to sebastianbergmann/phpunit that referenced this pull request Apr 28, 2019
@sebastianbergmann
Copy link

Sorry for the noise, seems to work now. I assumed this issue to still exist as I am still seeing build failures of PHPUnit on PHP 8.0-dev that should be fixed by php/php-src@e311f2a.

@nikic
Copy link
Contributor Author

nikic commented Apr 28, 2019

@sebastianbergmann That's odd. Your build log says "PHP 8.0.0-dev (cli) (built: Feb 11 2019 07:59:12) ( ZTS )", so this build is indeed outdated. However I got a recent build in apcu: https://travis-ci.org/krakjoe/apcu/jobs/525534805#L492 Both run on trusty builders, so I'm not sure where this difference comes from.

@nikic
Copy link
Contributor Author

nikic commented Apr 28, 2019

@sebastianbergmann Oh, I see, you are using master instead of nightly. Probably the aliasing broke at some point...

@sebastianbergmann
Copy link

sigh Should I change master to nightly in all my projects now or wait until the aliasing issue is fixed?

@nikic
Copy link
Contributor Author

nikic commented Apr 28, 2019

I've verified that nightly vs master is indeed what makes the difference here. Looking at the build logs, both artifacts are uploaded to AWS:

INFO: uploading: /home/travis/build/travis-ci/php-src-builder/14.04/php-master.tar.bz2 (size: 62MB)
  download_url: https://s3.amazonaws.com/[secure]/binaries/ubuntu/14.04/x86_64/php-master.tar.bz2
INFO: uploading: /home/travis/build/travis-ci/php-src-builder/14.04/php-master.tar.bz2.sha256sum.txt (size: 85B)
  download_url: https://s3.amazonaws.com/[secure]/binaries/ubuntu/14.04/x86_64/php-master.tar.bz2.sha256sum.txt
INFO: uploading: /home/travis/build/travis-ci/php-src-builder/14.04/php-nightly.tar.bz2 (size: 62MB)
  download_url: https://s3.amazonaws.com/[secure]/binaries/ubuntu/14.04/x86_64/php-nightly.tar.bz2
INFO: uploading: /home/travis/build/travis-ci/php-src-builder/14.04/php-nightly.tar.bz2.sha256sum.txt (size: 86B)
  download_url: https://s3.amazonaws.com/[secure]/binaries/ubuntu/14.04/x86_64/php-nightly.tar.bz2.sha256sum.txt

The actual downloads happen from Google Cloud Storage though:

Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/php/binaries/ubuntu/14.04/x86_64/php-master.tar.bz2

I have no idea how the artifacts get from AWS to GCS though -- probably some handling for the php-master archive is missing.

sebastianbergmann added a commit to sebastianbergmann/phpunit that referenced this pull request Apr 28, 2019
@BanzaiMan
Copy link
Contributor

There is a lag between the S3 upload to php-arc-builder, and the sync from S3 to GCS, where your builds will pull the archives. (To save on bandwidth cost.)

I’m not sure how the names master and nightly should work differently at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants