-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link against oniguruma statically #36
Conversation
c4be26d
to
5672906
Compare
* Move snapshot tests to a separate stage to always have them run last, regardless of other stages * Install libonig-dev as it is temporarily required for snapshot and nighly tests (see travis-ci/php-src-builder#36)
* Install libonig-dev as it is temporarily required for snapshot and nighly tests (see travis-ci/php-src-builder#36)
@BanzaiMan seeing you helped merge #31, can you take a look here as well, please? People are avoiding testing PHP 7.4 snapshots because of this |
Ping |
Thank you, @BanzaiMan. How often is PHP |
@sebastianbergmann The build does happen every day, see https://travis-ci.org/travis-ci/php-src-builder/builds -- it just doesn't always succeed. If there are upstream changes in the build system (of which there are a lot in 7.4) then Travis may fail to produce new snapshot builds for a while, until the issue is resolved. This change should've gone out already though. Are you still seeing issues? |
This reverts commit 9c750f0.
Sorry for the noise, seems to work now. I assumed this issue to still exist as I am still seeing build failures of PHPUnit on PHP 8.0-dev that should be fixed by php/php-src@e311f2a. |
@sebastianbergmann That's odd. Your build log says "PHP 8.0.0-dev (cli) (built: Feb 11 2019 07:59:12) ( ZTS )", so this build is indeed outdated. However I got a recent build in apcu: https://travis-ci.org/krakjoe/apcu/jobs/525534805#L492 Both run on trusty builders, so I'm not sure where this difference comes from. |
@sebastianbergmann Oh, I see, you are using |
sigh Should I change |
I've verified that nightly vs master is indeed what makes the difference here. Looking at the build logs, both artifacts are uploaded to AWS:
The actual downloads happen from Google Cloud Storage though:
I have no idea how the artifacts get from AWS to GCS though -- probably some handling for the php-master archive is missing. |
There is a lag between the S3 upload to php-arc-builder, and the sync from S3 to GCS, where your builds will pull the archives. (To save on bandwidth cost.) I’m not sure how the names |
No description provided.