-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default script for Objective-C to xctool #109
Conversation
Here's an example of a build using this code: https://staging.travis-ci.org/henrikhodne/Mantle/builds/387513. |
This should make the script more backwards compatible, as we used to have xcode_sdk and xcode_scheme.
Excited about this :-) Requiring We might also want to make Let's say you had a regular iOS project and did the following with just the
xctool will probably build your app against the device SDK But, if you did
Now, xctool is going to build against the Making SDK explicit (or setting the default to iphonesimulator) would make the SDK selection less ambiguous. |
I have to admit I'm not so sure about changing this after I found out that xctool doesn't support CocoaPods out of the box (due to the "find implicit dependencies" bug, see facebookarchive/xctool#16). Thinking about good ways to work around this. |
@henrikhodne Yeah, I'm going to look at that really soon. It seems fixable. |
Any updates on this issue? |
@joshk I'm working on making xctool play nice with implicit dependencies right now. Will follow up in a bit when I get it figured out. |
@henrikhodne, @joshk hey guys, as of last week, xctool will play nice out-of-the-box with CocoaPods and other projects that use Xcode's Find Implicit Dependencies feature. This is in the 0.1.7 release, which is up on homebrew now. I've also put up binary releases if that makes life easier for travis-ci. (https://github.com/facebook/xctool/releases) |
@fpotter Thanks. I need to revamp the way we update our VMs and workers, will look into this soon, though. |
Conflicts: spec/templates/header.sh
Use xctool as the default OS X build script
This changes the default build script for Objective-C build to use xctool if a valid configuration is passed.
I'm not completely sure about the config variable names. If we prefix them with
xcode_
we'll maintain backwards compatibility, although the old variables were never documented. I should probably check if anyone is using them.TODO:
To the people I'm about to ping to ask to do a quick sanity check on this:
This change makes
xctool
the default script if a scheme is specified in the.travis.yml
file, like this:Does it seem good to require workspace/project and scheme? Can one or more be left out, or should I include more? There's also
xctool_args
, which can be added to pass arbritary args to xctool, like-sdk
.The above config will run this command:
Should the default command be something else?