Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for more valid dotnet versions #1340

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Fix for more valid dotnet versions #1340

merged 1 commit into from
Mar 19, 2018

Conversation

JustArchi
Copy link
Contributor

2.1.101 is completely valid SDK version, as well as 2.1.300-preview1-008174

cc @Joshua-Anderson @akoeplinger @nterry

`2.1.101` is completely valid SDK version, as well as `2.1.300-preview1-008174`

cc @Joshua-Anderson @akoeplinger @nterry
ojji added a commit to ojji/RedisearchSharp that referenced this pull request Mar 18, 2018
- Travis CI does not support all proper dotnet sdk versions, the latest version (2.1.101) is failing until travis-ci/travis-build#1340 is accepted.
@akoeplinger
Copy link
Contributor

@BanzaiMan this should be good to be merged and deployed to production

Copy link

@0Lucifer0 0Lucifer0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BanzaiMan BanzaiMan merged commit a731db0 into travis-ci:master Mar 19, 2018
@JustArchi JustArchi deleted the patch-1 branch March 19, 2018 16:35
haf added a commit to causiq/logary that referenced this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants