Respect update: true in apt addon
#1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
native-api
suggested changes
Jun 19, 2019
There was a problem hiding this comment.
- Why not just
apt updateinbefore_preparewhenever the directive is specified? KISS. sources:should probably implyupdate:truesince it would have no effect otherwise as per https://travis-ci.community/t/apt-update-doesnt-work-unless-you-also-add-some-package-s/3816/7?u=native-api
lib/travis/build/addons/apt.rb
Outdated
| unless config[:update] | ||
| # this is run elsewhere when sources are added | ||
| sh.cmd 'travis_apt_get_update', retry: true, echo: true, timing: true | ||
| end |
There was a problem hiding this comment.
This will make update: work backwards if packages: is specified and sources: is not.
BanzaiMan
force-pushed
the
ha-apt-update
branch
from
a60ce26
to
414571b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it ran only when we install packages