Double-quote variable values for set and export commands
#1865
Conversation
native-api
force-pushed
the
quote_varvalues
branch
3 times, most recently
from
cd27841
to
e1d0b46
Compare
|
Planning to merge and deploy on Monday. |
native-api
force-pushed
the
quote_varvalues
branch
from
e1d0b46
to
0c44f40
Compare
|
I think one of these changes might have broken Travis variables: https://travis-ci.community/t/travis-incorrectly-double-quotes-environment-variables/7496 |
|
Sorry about that. We've reverted this and deployed the revert. Please restart the affected build(s). We'll look at the issue that this PR aimed to address at a later time. |
|
As per https://travis-ci.community/t/travis-incorrectly-double-quotes-environment-variables/7496/9, this turns out to be an undocumented grey area thus the behavior change wasn't caught by tests. We should decide what the expected behavior would be before trying this again. Why unquoting doesn't restore the old behavior is a mystery to me for now. |
For the record, found it. travis-build/lib/travis/build/env/var.rb Line 13 in 8724886 var=value pairs per entry.
|
https://travis-ci.community/t/sonarqube-plugin-failing-due-to-failed-export/7429