Move hhvm-nightly package installation to 'configure' #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BanzaiMan
force-pushed
the
ha-bug-more-hhvm-fixes
branch
from
8861569
to
c33fb24
Compare
Ideally, phpenv would be able to do some magic so that it can install hhvm-nightly without `sudo`, but until then, we will hack our way here.
BanzaiMan
force-pushed
the
ha-bug-more-hhvm-fixes
branch
from
c33fb24
to
a5702ad
Compare
| end | ||
|
|
||
| private | ||
| def insatll_hhvm_nightly |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
except for that one misspelling
|
Ported to sf-sexp-2 c5e5a73 |
|
This one is also obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
hhvm-nightlyto be usable forsudo-less users, and allows us to inject a couple of changes in its init file.