git: fix typo in rm_key

[sarahhodne]

The key that we install is named ~/.ssh/id_rsa, not ~/.ssh/source_rsa.

[joshk]

Please do not merge this as it is a change in behavior which some customers may be relying on.

[sarahhodne]

If so we should probably just remove the step entirely?

Also, the key is still in the SSH agent, so it's still usable.

[joshk]

Hmmmmmmmmm, ok, that is a good point that it is in the SSH agent.

@meatballhat @rkh @svenfuchs thoughts and opinions?

[meatballhat]

I think we can safely remove this step. Those users who really need the identity to be gone have to interact with ssh-add anyway.

[joshk]

@meatballhat do you mean remove the code?

[meatballhat]

@joshk sorry for ambiguity. Yes, remove the code 😺

[joshk]

Sounds good to me.

[deckar01]

For historical context, "source_rsa" is not a typo, it was the original location that wrote the configured private key for git. At one point the code to copy the source key was removed then later reimplemented using "id_rsa" without updating the key cleanup code.

[joshk]

@henrikhodne can this PR be closed and a new one opened to remove the code which removes the ssh key?

[meatballhat]

No longer valid!