Add support for Common Lisp #625
Conversation
|
Thanks for opening this PR. Please read https://docs.travis-ci.com/user/languages/community-supported-languages/ and follow the process described there. |
|
I'm already following the process: for step 1 we're already 6(https://github.com/orgs/lisp-travis/people). And this is step 2. If there's anything I missed, please advise. |
|
The maintainers are not identified in this PR. |
| system_keyword = ":#{config[:system]}" | ||
| sh.cmd %Q[\ | ||
| ros -e '(ql:quickload #{system_keyword})' \\ | ||
| -e '(unless (asdf:test-system #{system_keyword}) \\ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Will this Common Lisp support documented somehow in the official Travis documentation? |
|
Description updated with the names. |
|
Please add the maintainers' names to the code itself. |
|
Done. |
|
Sorry for not being more explicit, but the maintainers' names need to be visible to the users, so that when they report problems on GitHub they know whom to cc. (Though often they forget this.) |
|
Done |
|
|
||
| def configure | ||
| super | ||
| sh.echo "If you encounter any issues with Common Lisp support, please Cc @tmccombs, @luismbo, @snmsts or @sionescu." |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
How about now ? Btw, this should probably go into the official documentation. |
|
Let us test this on staging (https://staging.travis-ci.org) this Friday (Feb. 26 HST). Thanks. |
|
How will testing happen ? I'll be gone during the weekend so I probably won't be around to answer questions. |
|
To test, I will deploy the PR, and you run the tests on staging. If you are not around, then we will have to figure out some other ways to synchronize the testing. |
|
Then I will test something. HST... Hawaii? |
|
I will try to be around for testing too. |
|
Yes. Hawaii Standard Time. I'll update this thread when it is deployed to staging. Thanks. |
|
This has been deployed to staging. Please test it. |
|
I won't be able to do any testing until tomorrow. @snmsts any luck? |
|
https://staging.travis-ci.org/snmsts/quri/builds/491735 do I have luck? |
|
@snmsts that doesn't look very lucky, no. :-) |
|
it's hard to test if the process are stop at anounce part... :-) Can we try it again? with at least fe36998 applied. |
|
Sorry about the delay. We'll try again on Friday. |
|
Thank you. |
|
@9ab98e3 has been deployed to staging. |
|
Did anyone test this last week? I deployed it to staging once again, but I might take it down for testing other things over the weekend. |
|
I'm sorry for not being update. https://staging.travis-ci.org/snmsts/quri/jobs/492013 the result was something wired.It should be debug. |
People who have pledged to maintain the Lisp support:
Stelian Ionescu @sionescu, Thayne McCombs @tmccombs, Luís Oliveira @luismbo and SANO Masatoshi @snmsts.