Add caching support for GCE via GCS and AWS V2-compatible signed URL #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS has a peculiar rule about the bucket's hostname depending on the region it resides in. This is not extendable to other service providers, so we devise a means of varying such a rule based on the implementation.
Also add Gcs specs (most signature specs fail at the moment).
This makes the intent of this method clearer.
String is not useful here
It is not used
Using the example in http://docs.aws.amazon.com/AmazonS3/latest/dev/RESTAuthentication.html#RESTAuthenticationExamples StringToSign: ``` GET\n \n \n Tue, 27 Mar 2007 19:36:42 +0000\n /johnsmith/photos/puppy.jpg ``` Request: ``` GET /photos/puppy.jpg HTTP/1.1 Host: johnsmith.s3.amazonaws.com Date: Tue, 27 Mar 2007 19:36:42 +0000 Authorization: AWS AKIAIOSFODNN7EXAMPLE:bWq2s1WEIj+Ydj0vQ697zp+IXMU= ```
scheduler puts this on the wire, for testing purposes
logger doesn't seem available
We changed the payload put in by scheduler
Ensure subsequent `casher` invocations correctly run
No longer needed
It is unused.
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds caching support for GCE.
Using
cache_settings(see travis-ci/travis-scheduler#14) in the build payload, we configure a subclass ofDirectoryCachefor caching.Tests: