Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak travis_wait #975

Merged
merged 4 commits into from May 24, 2018
Merged

Tweak travis_wait #975

merged 4 commits into from May 24, 2018

Conversation

BanzaiMan
Copy link
Contributor

@BanzaiMan BanzaiMan commented Mar 8, 2017

Instead of redirecting I/O and sending commands passed to the background, we simply start a job which write audio bells every 60 seconds or so to STDOUT, so that the job we want to live long does not get killed.

@BanzaiMan
Copy link
Contributor Author

@BanzaiMan
Copy link
Contributor Author

@solarce
Copy link
Contributor

solarce commented Mar 8, 2017

What's the risk of this resulting in users hitting the 4mb log limit, if those users are counting on the existing travis_wait behavior of suppressing all output?

Could this behavior be made optional at first?

@BanzaiMan
Copy link
Contributor Author

@solarce That is a valid point. The risk is there. We will do well to make this less intrusive.


echo -e "\n${ANSI_RED}Timeout (${timeout} minutes) reached. Terminating \"$@\"${ANSI_RESET}\n"
kill -9 $cmd_pid
travis_cmd "$*"

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this change in behavior will mean that even if the command returns immediately, there will be a visual bell written to output every 60s. Is that acceptable? Given the amount of ANSI code noise in our archived logs, I tend to think it's hardly going to be noticed.

@domenkozar
Copy link
Contributor

While I haven't tested this solution, we did hit the quoting bug as well. Using travis_wait 20 sleep 4600& as a workaround

@abitrolly
Copy link

So, what is required to merge this?

@calvn
Copy link

calvn commented Apr 24, 2018

@BanzaiMan any update as to when/if this will be merged? It'd be very useful to have output get streamed as the build is ran, rather than wait for travis_wait to timeout or exit on error.

@BanzaiMan BanzaiMan temporarily deployed to travis-build-staging May 24, 2018 15:35 Inactive
@BanzaiMan
Copy link
Contributor Author

I'm going to revert this for now, in light of travis-ci/travis-ci#9663.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants