New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak travis_wait #975
Tweak travis_wait #975
Conversation
travis_jigger is no longer defined
A simple test is found here: https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/547416 |
Some GitHub issues that may benefit from this PR: travis-ci/travis-ci#5281 |
What's the risk of this resulting in users hitting the 4mb log limit, if those users are counting on the existing Could this behavior be made optional at first? |
@solarce That is a valid point. The risk is there. We will do well to make this less intrusive. |
|
||
echo -e "\n${ANSI_RED}Timeout (${timeout} minutes) reached. Terminating \"$@\"${ANSI_RESET}\n" | ||
kill -9 $cmd_pid | ||
travis_cmd "$*" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, this change in behavior will mean that even if the command returns immediately, there will be a visual bell written to output every 60s. Is that acceptable? Given the amount of ANSI code noise in our archived logs, I tend to think it's hardly going to be noticed.
While I haven't tested this solution, we did hit the quoting bug as well. Using |
So, what is required to merge this? |
@BanzaiMan any update as to when/if this will be merged? It'd be very useful to have output get streamed as the build is ran, rather than wait for |
I'm going to revert this for now, in light of travis-ci/travis-ci#9663. |
Instead of redirecting I/O and sending commands passed to the background, we simply start a job which write audio bells every 60 seconds or so to STDOUT, so that the job we want to live long does not get killed.