Add best practices and style guidelines #394
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sent out a team-wide email about this a little while ago, and decided to start working a bit on this.
From that email:
There are several things I'd like to get feedback on here.
Pretty much all of the entries in this is taken from Thoughtbot's guides, but I've tried to modify them whenever the practice inside of Travis is different. In general, especially for the style guidelines, I don't think the exact style matters that much, it's more important to be consistent. If you see something that we do differently, or there's an entry you don't understand why is there, or you disagree with it, please leave an inline comment.
And a last question to Travis CI contributors or people who think they might contribute to Travis CI: What do you think of this? Will this make it harder for you to contribute? How could we make sure that contributing is still a smooth process?
I'm happy to talk about this over other media as well, such as Skype or Google Hangout, although I would like to at least summarize the content here to allow more people to comment on it as well.