Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Clojure guide #55

Merged
merged 3 commits into from Mar 8, 2012
Merged

Improve Clojure guide #55

merged 3 commits into from Mar 8, 2012

Conversation

technomancy
Copy link
Contributor

This should make the Clojure guide a little more idiomatic.

User-level plugins are not appropriate for CI situations.
The javac task isn't a good example since it should be run for you
automatically. Also emphasize that :hooks are usually a better solution.
steveklabnik added a commit that referenced this pull request Mar 8, 2012
@steveklabnik steveklabnik merged commit 06b20c0 into travis-ci:master Mar 8, 2012
@steveklabnik
Copy link
Contributor

Thanks! Clojure is awesome.

@technomancy
Copy link
Contributor Author

No problem. Let me know once you get support for Leiningen 2 and I'll be happy to help review docs for that.

@michaelklishin
Copy link
Contributor

@technomancy I disagree with the removal of the Dependency Management section. For a few reasons:

  • It is useful for developers to understand what Travis CI Clojure builder runs.
  • We usually explain that it is possible to override this, yada yada yada, in or around that section.
  • Finally, it is consistent with the rest of the guides.

I take another look and possibly revert that one change.

@michaelklishin
Copy link
Contributor

Also, the :plugins part does not seem to mention that this feature is a 2.0 => 1.7 backport so people who use 1.6.2 locally will have trouble using it. I will add it.

@technomancy
Copy link
Contributor Author

I see where you're coming from, but I think this is misleading. There is
no reason for the Travis builder to run lein deps. Seeing that it's
done here just reinforces this idea people have that there is some
irrelevant incantation that you have to run before you can start using
Leiningen; basically it's going to cause cargo-culting. I think the
inclusion of the lein protobuf example is a better way to show people
how to override the install process.

I do agree that it's worth mentioning that :plugins will not work in
older versions of Leiningen and that they can use :dev-dependencies in
that case. We should not mention lein plugin install because that
should not be used for plugins that are needed for successful CI runs.

@michaelklishin
Copy link
Contributor

Agreed, documentation examples do form habits and impression of various tools. I will bring Dependency Management section back but only make it say that with Leiningen, it is almost always unnecessary to run lein deps manually.

@michaelklishin
Copy link
Contributor

Also, I will remove lein deps run in the builder when I get to adding Lein 2 support.

@technomancy
Copy link
Contributor Author

Sounds good; thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants