Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to configure notifications for forks separately #329

Closed
lsmith77 opened this issue Nov 23, 2011 · 12 comments
Closed

make it possible to configure notifications for forks separately #329

lsmith77 opened this issue Nov 23, 2011 · 12 comments

Comments

@lsmith77
Copy link

the fork configuration should be used if the given repository is not the root on github:

notifications:
    irc: "irc.freenode.org#foobar"

fork_notifications:
    irc: false

The above is just an illustration. Maybe it would be better to allow a single "forks" section that simply overrides the default config?

language: php

php:
    - 5.3
    - 5.4

notifications:
    irc: "irc.freenode.org#foobar"

forks:
    php: 5.3

    notifications:
        irc: false
@svenfuchs
Copy link
Contributor

Not sure this solves the problem though.

How would I configure my forks to notify me? E.g. i have svenfuchs/i18n which is a fork of the Github root mattetti/i18n. svenfuchs/i18n is the "official" repository, i.e. the one where development happens for the last years. Afaik this is not an exception but there are lots of repositories like this.

Also, how would we deal with branches in this situation? We currently simply fetch the .travis.yml file that belongs to the commit hash that github has passed to us. This would be a lot more complicated with the proposed approach.

My current thinking is that we'd want to ensure fork owners have touched their .travis.yml and otherwise ignore it.

E.g. if the current repository is a fork we could require something as simple as this be present in the .travis.yml file:

 # in svenfuchs/i18n/blob/master/.travis.yml
 fork: svenfuchs/i18n

If this attribute is not present or does not equal the current repository name then we know that the fork owner has not touched the .travis.yml file and has not verified the notification options (and other options, for that matter).

@lsmith77
Copy link
Author

that could work. as for "How would I configure my forks to notify me?" imho there should also be a way to configure the notifications to only notify the committer, but not the repo owner.

@svenfuchs
Copy link
Contributor

I agree. Although I'd say that's a separate issue. Could you open another ticket for that?

Thank you :)

@lsmith77
Copy link
Author

done #330

@svenfuchs
Copy link
Contributor

muchas gracias :)

@Maks3w
Copy link

Maks3w commented May 12, 2012

Could this schema be usefull here?

This override the default notification value if the repository.owner.login sended in the payload (http://help.github.com/post-receive-hooks/) match with <repository.owner.name>

notifications:
    <repository.owner.name>:
        irc: ...
        email: ...

For example:

notifications:
    svenfuchs:
        irc: irc.freenode.net#travis

This means that only the commits sended from svenfuchs will be notified to #travis channel. The email notifications still with the default values.

@elf-pavlik
Copy link

just spotted in one projects notifications getting crazy after few people forking it... any updates on this issue?

@kenperkins
Copy link

I'm also very interested in this feature. I'll be managing our (@rackspace's) official contributions to @nodejitsu's pkgcloud, and I'd love to get CI enabled on the fork so I can have visibility to changes as they're going in before I PR them to the parent.

Obviously, I'd love any suggestions that work as well!

@joshk
Copy link
Contributor

joshk commented Apr 12, 2013

I am sorry for the delay in this, I will start mapping out what is needed on our end to make notifications better. I don't have an ETA for it, but I will try to give it some love soon.

On 10/04/2013, at 7:43 PM, Ken Perkins notifications@github.com wrote:

I'm also very interested in this feature. I'll be managing our (@rackspace's) official contributions to @nodejitsu's pkgcloud, and I'd love to get CI enabled on the fork so I can have visibility to changes as they're going in before I PR them to the parent.

Obviously, I'd love any suggestions that work as well!


Reply to this email directly or view it on GitHub.

@marcusramberg
Copy link

prod.

@kraih
Copy link

kraih commented Sep 21, 2013

👍 Notifications are currently unusable if you have a few broken forks people keep committing to.

@sarahhodne
Copy link
Contributor

I'm going to close this in favor of #1094. We've discussed numerous ways of fixing the various notification issues, and this should be fixed by moving the notification settings to a per-repository settings panel.

jhass added a commit to diaspora/diaspora that referenced this issue Apr 27, 2016
encrypting the channel setting

Courtesy of mozilla/build-tools@c13a297
jhass added a commit to crystal-lang/crystal that referenced this issue Apr 27, 2016
encrypting the channel setting

Courtesy of mozilla/build-tools@c13a297
LebedevRI added a commit to LebedevRI/darktable that referenced this issue Oct 29, 2016
waja added a commit to waja/monitoring-plugins that referenced this issue Nov 29, 2016
By encrypting the notification settings
waja added a commit to monitoring-plugins/monitoring-plugins that referenced this issue Nov 29, 2016
By encrypting the notification settings. This still fail for ppl
with push access to the origin repro while pushing to their own
clone.
waja added a commit to waja/monitoring-plugins that referenced this issue Nov 29, 2016
Encrypted env variables are not available for PRs

This reverts commit fe69d36.
myii added a commit to myii/ssf-formula that referenced this issue May 20, 2020
* Use `%2F` for the forward slash in the topic name:
  - https://docs.travis-ci.com/user/triggering-builds/
  - https://www.degraeve.com/reference/urlencoding.php
* Use Travis `if` conditional rather than `secret` encrypted enviroment
  variable workaround suggested:
  - Not a secret, just the bot's API key
  - Need to be able to modify parts of the URL in certain situations,
    such as the weekly `master` branch tests
  - References:
    + https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables
    + travis-ci/travis-ci#329
    + travis-ci/travis-ci#1094
    + travis-ci/travis-ci#5063
    + travis-ci/travis-ci#6100
    + mozilla/build-tools@c13a297
myii added a commit to myii/ssf-formula that referenced this issue May 20, 2020
* Use `%2F` for the forward slash in the topic name:
  - https://docs.travis-ci.com/user/triggering-builds/
  - https://www.degraeve.com/reference/urlencoding.php
* Use Travis `if` conditional rather than `secret` encrypted enviroment
  variable workaround suggested:
  - Not a secret, just the bot's API key
  - Need to be able to modify parts of the URL in certain situations,
    such as the weekly `master` branch tests
  - References:
    + https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables
    + travis-ci/travis-ci#329
    + travis-ci/travis-ci#1094
    + travis-ci/travis-ci#5063
    + travis-ci/travis-ci#6100
    + mozilla/build-tools@c13a297
myii added a commit to myii/ssf-formula that referenced this issue May 21, 2020
* Use `%2F` for the forward slash in the topic name:
  - https://docs.travis-ci.com/user/triggering-builds/
  - https://www.degraeve.com/reference/urlencoding.php
* Use Travis `if` conditional rather than `secret` encrypted enviroment
  variable workaround suggested:
  - Not a secret, just the bot's API key
  - Need to be able to modify parts of the URL in certain situations,
    such as the weekly `master` branch tests
  - References:
    + https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables
    + travis-ci/travis-ci#329
    + travis-ci/travis-ci#1094
    + travis-ci/travis-ci#5063
    + travis-ci/travis-ci#6100
    + mozilla/build-tools@c13a297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants