New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it possible to configure notifications for forks separately #329
Comments
Not sure this solves the problem though. How would I configure my forks to notify me? E.g. i have Also, how would we deal with branches in this situation? We currently simply fetch the My current thinking is that we'd want to ensure fork owners have touched their E.g. if the current repository is a fork we could require something as simple as this be present in the
If this attribute is not present or does not equal the current repository name then we know that the fork owner has not touched the |
that could work. as for "How would I configure my forks to notify me?" imho there should also be a way to configure the notifications to only notify the committer, but not the repo owner. |
I agree. Although I'd say that's a separate issue. Could you open another ticket for that? Thank you :) |
done #330 |
muchas gracias :) |
Could this schema be usefull here? This override the default notification value if the notifications:
<repository.owner.name>:
irc: ...
email: ... For example: notifications:
svenfuchs:
irc: irc.freenode.net#travis This means that only the commits sended from |
just spotted in one projects notifications getting crazy after few people forking it... any updates on this issue? |
I'm also very interested in this feature. I'll be managing our (@rackspace's) official contributions to @nodejitsu's pkgcloud, and I'd love to get CI enabled on the fork so I can have visibility to changes as they're going in before I PR them to the parent. Obviously, I'd love any suggestions that work as well! |
I am sorry for the delay in this, I will start mapping out what is needed on our end to make notifications better. I don't have an ETA for it, but I will try to give it some love soon. On 10/04/2013, at 7:43 PM, Ken Perkins notifications@github.com wrote:
|
prod. |
👍 Notifications are currently unusable if you have a few broken forks people keep committing to. |
I'm going to close this in favor of #1094. We've discussed numerous ways of fixing the various notification issues, and this should be fixed by moving the notification settings to a per-repository settings panel. |
encrypting the channel setting Courtesy of mozilla/build-tools@c13a297
encrypting the channel setting Courtesy of mozilla/build-tools@c13a297
By encrypting the notification settings
By encrypting the notification settings. This still fail for ppl with push access to the origin repro while pushing to their own clone.
Encrypted env variables are not available for PRs This reverts commit fe69d36.
* Use `%2F` for the forward slash in the topic name: - https://docs.travis-ci.com/user/triggering-builds/ - https://www.degraeve.com/reference/urlencoding.php * Use Travis `if` conditional rather than `secret` encrypted enviroment variable workaround suggested: - Not a secret, just the bot's API key - Need to be able to modify parts of the URL in certain situations, such as the weekly `master` branch tests - References: + https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables + travis-ci/travis-ci#329 + travis-ci/travis-ci#1094 + travis-ci/travis-ci#5063 + travis-ci/travis-ci#6100 + mozilla/build-tools@c13a297
* Use `%2F` for the forward slash in the topic name: - https://docs.travis-ci.com/user/triggering-builds/ - https://www.degraeve.com/reference/urlencoding.php * Use Travis `if` conditional rather than `secret` encrypted enviroment variable workaround suggested: - Not a secret, just the bot's API key - Need to be able to modify parts of the URL in certain situations, such as the weekly `master` branch tests - References: + https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables + travis-ci/travis-ci#329 + travis-ci/travis-ci#1094 + travis-ci/travis-ci#5063 + travis-ci/travis-ci#6100 + mozilla/build-tools@c13a297
* Use `%2F` for the forward slash in the topic name: - https://docs.travis-ci.com/user/triggering-builds/ - https://www.degraeve.com/reference/urlencoding.php * Use Travis `if` conditional rather than `secret` encrypted enviroment variable workaround suggested: - Not a secret, just the bot's API key - Need to be able to modify parts of the URL in certain situations, such as the weekly `master` branch tests - References: + https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables + travis-ci/travis-ci#329 + travis-ci/travis-ci#1094 + travis-ci/travis-ci#5063 + travis-ci/travis-ci#6100 + mozilla/build-tools@c13a297
the fork configuration should be used if the given repository is not the root on github:
The above is just an illustration. Maybe it would be better to allow a single "forks" section that simply overrides the default config?
The text was updated successfully, but these errors were encountered: