Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine Yard deployment is skipped when the environment is specified via branch name #6212

Closed
BanzaiMan opened this issue Jun 22, 2016 · 2 comments
Closed

Engine Yard deployment is skipped when the environment is specified via branch name #6212

BanzaiMan opened this issue Jun 22, 2016 · 2 comments
Assignees
@BanzaiMan
Labels
deployment

Comments

@BanzaiMan
Copy link
Contributor

https://docs.travis-ci.com/user/deployment/engineyard#Application-or-Environment-to-deploy

This branch specific settings are possible for all options (except on) and can be very useful for deploying to different environments:

deploy:
  provider: engineyard
  api_key: ...
  environment:
    master: staging
    production: production

This is currently broken.

See reproduction here: https://travis-ci.org/BanzaiMan/travis_production_test/builds/139574415
@BanzaiMan BanzaiMan self-assigned this Jun 22, 2016
@BanzaiMan
Copy link
Contributor Author

I believe this is the culprit: travis-ci/travis-build@39323f0. This changed the way we look up default branches in certain conditions. We accounted for the heroku provider's app key, but not EY's environment key.

BanzaiMan added a commit to travis-ci/travis-build that referenced this issue Jun 22, 2016
@BanzaiMan
Consider deploy.environment value when finidng default branch
7def8b2 
This is a continuation of @39323f0, which addressed the issue of
finding the default branch name for deployment for Heroku.

In addition to the `app` key, we support the `environment` key value
in `engineyard` provider.
This was omitted in the previous commit, leading to
travis-ci/travis-ci#6212

Thus, this commit resolves travis-ci/travis-ci#6212
BanzaiMan added a commit to travis-ci/travis-build that referenced this issue Jun 23, 2016
@BanzaiMan
Consider deploy.environment value when finidng default branch
7b1f197 
This is a continuation of @39323f0, which addressed the issue of
finding the default branch name for deployment for Heroku.

In addition to the `app` key, we support the `environment` key value
in `engineyard` provider.
This was omitted in the previous commit, leading to
travis-ci/travis-ci#6212

Thus, this commit resolves travis-ci/travis-ci#6212
@BanzaiMan BanzaiMan mentioned this issue Jun 23, 2016
Closed
BanzaiMan added a commit to travis-ci/travis-build that referenced this issue Jun 23, 2016
@BanzaiMan
Consider deploy.environment value when finidng default branch
8c159dd 
This is a continuation of @39323f0, which addressed the issue of
finding the default branch name for deployment for Heroku.

In addition to the `app` key, we support the `environment` key value
in `engineyard` provider.
This was omitted in the previous commit, leading to
travis-ci/travis-ci#6212

Thus, this commit resolves travis-ci/travis-ci#6212
BanzaiMan added a commit to travis-ci/travis-build that referenced this issue Jun 23, 2016
@BanzaiMan
Skip deploy.edge when looking for branch names for deployment
a77268e 
Instead of gathering the branches in `deploy.*.app` key values,
we revert to the old logic of scraping `deploy.*.*`, except
`deploy.edge.*`.
`deploy.edge` is used for dpl testing instead. Using it for
inspecting branch names is wrong, and can lead to
travis-ci/travis-ci#6212.
@BanzaiMan BanzaiMan mentioned this issue Jun 23, 2016
Merged
@BanzaiMan
Copy link
Contributor Author

This was fixed by travis-ci/travis-build#752.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BanzaiMan BanzaiMan

Labels
deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider deploy.environment value when finidng default branch travis-ci/travis-build
1 participant
@BanzaiMan