Exit with non-zero status code on .travis.yml with issues #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When issues are found with the .travis.yml file exit with a non-zero status code. This resolve issue [#3](https://github.com/travis-ci/travis-lint/issues/3 "Issue #3 for travis-lint"). Note: Feature is tested by hand. I will add a spec for this in a later commit.
If a .travis.yml file has issues the Travis::Lint::Runner should exit with a non-zero exit status. This is capture in the travis_lint_runner_spec.rb
The test run should not interfere with the rspec output. Therefore stdout is capture by an instance of StringIO.
|
Thank you. Extra points for adding specs that capture stdout. |
michaelklishin
added a commit
that referenced
this pull request
Feb 27, 2012
Exit with non-zero status code on .travis.yml with issues
|
We will release next travis-lint version later this week |
|
Great! looking forward to it. |
|
1.3.0 is up on rubygems.org |
|
Great, I will upgrade to 1.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issues #3.
Travis::Lint::Runnerhas a one-line change i.e. to quit with a non-zero exit code when issues are found with the.travis.ymlfile.This behavior is specified in a spec file:
travis_lint_runner_spec.rb.