Skip to content

Commit

Permalink
Add reset for log limited flag (#669)
Browse files Browse the repository at this point in the history
Restarted jobs that formerly had truncated logs were showing
as truncated immediately, even when they only had a few log
lines showing. Log truncation was probably added before the
job reset UI, so when truncation broke, no handling was added
for resetting the limited flag when a job was restarted.

Adding automated testing for this might be difficult, but I’ll
try it in my separate pull request for overall truncation tests.
  • Loading branch information
backspace committed Sep 6, 2016
1 parent 34a3f86 commit 9d2fb1b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions app/components/log-content.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export default Ember.Component.extend({

createEngine(log) {
if (log || (log = this.get('log'))) {
this.set('limited', false);
this.clearLogElement();
log.onClear(() => {
this.teardownLog();
Expand Down

0 comments on commit 9d2fb1b

Please sign in to comment.