Update switch appearance #1613
Closed
Update switch appearance #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests will fail for various known reasons and probably some unknown! There are several obvious places to improve on this implementation, but with production data, it at least shows the user and orgs in the sidebar.
Why is it /orgs but the resource is organization? 😞
ugh this is hideous
I don’t know how this was ever working, as urlForQueryRecord is unused by V3Adapter. OOPS hmmmm
The existing implementation doesn’t have any special error-handling, so this can use the default facilities.
This involves much hackery, but progress!
ughhhhhhhh
How useful is it anyway? 😆
This is a pretty wide-reaching change but the tests all pass…
Now that I‘ve added an error for any other type of query, I think this is okay, but I’ll be seeking review.
This isn’t ready yet but oh welll
# Conflicts: # app/templates/accounts.hbs
Really I should just replace switch with switch-rounded at this point, but this is a side quest at the moment.
There are TOO MANY switch components, no?
|
I guess I might as well just do this the right way hehe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a place to store off the full conversion of all (?) switches in the application to a new look because #1604 has grown terribly large and I’m thinking about how I’ll break it up.