Update profile page for GitHub Apps #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2018
backspace
changed the title
oops I am v underslept
I tried to no avail to load them the way the API will actually work, I’ll have to return to it.
ugh!
I don’t understand why this is happening…?
obvsy!
This requires github_id to be added to the API, but that seems reasonable…???
The tests will fail for various known reasons and probably some unknown! There are several obvious places to improve on this implementation, but with production data, it at least shows the user and orgs in the sidebar.
This was referenced May 7, 2018
Closed
Merged
backspace
added a commit
that referenced
this pull request
May 7, 2018
This is extracted from #1604.
backspace
added a commit
that referenced
this pull request
May 7, 2018
This is extracted from #1604.
backspace
added a commit
that referenced
this pull request
May 7, 2018
This is extracted from #1604.
This is staying for now!
I don’t even know when this was fixed… but it is! Perhaps the problem will return with billing work. 🧐
Not sure why this is working now… 🙃
It’s fiiiiiine to not extract this
backspace
changed the title
|
I see thanks to Percy that it wasn’t a perfect breaking-up, as some images were missing for the landing page, but it’s GOOD ENOUGH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a long way to go.
ETA this is too unwieldy and I’ll be breaking it up, but not for a while.