Add Intercom #1619
Merged
Add Intercom #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a start!
This isn’t rendering for me locally…?
The Application doesn’t have access to the service yaaaa
joshk
reviewed
Apr 12, 2018
app/app.js
Outdated
| setIntercomUser(user) { | ||
| this.get('intercom').set('user.name', user.name); | ||
| this.get('intercom').set('user.email', user.email); | ||
| // FIXME createdAt? |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
joshk
previously requested changes
Apr 12, 2018
app/services/auth.js
Outdated
| @@ -161,7 +161,7 @@ export default Service.extend({ | |||
| if (proVersion && get(config, 'intercom.enabled')) { | |||
| this.get('intercom').set('user.name', user.name); | |||
| this.get('intercom').set('user.email', user.email); | |||
| // FIXME createdAt? | |||
| this.get('intercom').set('user.createdAt', user.last_synced_at); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This reverts commit b249b5b.
Testing via deployment is tedious hehe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.