*.scss: fix typos

[the-j0k3r]

There are probably more but this is as far I I was.

edit

there is this @ line 201

travis-web/app/styles/app/layouts/profile.scss

Line 201 in 96b4b0e

padding: 0.7em em 0.7em 0.5em;

introduced in #1520

Should be a value there no idea what it was intended for that em if I had to guess Id say 0.5em
if you wish, I can push that in here also.

[backspace]

Hey, thanks for this. I have a giant PR that’s awaiting cleanup and merging and I don’t want to introduce any merge conflicts, so I’ll look at this again after that‘s done.

[the-j0k3r]

No problem, I stumbled across this while making a dark style for travis-ci based on the generated css.

Where is that PR of yours? Ide like to have a look, I dread to have spent hours on making a dark style that wont work after that... 👅 💀 🔫

[backspace]

Sorry, I should have linked to it. It’s here, it’s the updates for GitHub Apps support and the displaying of open source repositories at travis-ci.com. It’s my plan this week to break it up into some more-manageable parts and merge them.

[the-j0k3r]

That looks trivial tbh, only the profile.scss file 6d67800 and 6d67800 is affected by your PR, and that is minimal, you should have no issues.

That said, I found loads of other issues which Im unsure about, like using floatwith display: inline-block and other warnings like padding: inherit 0 idk what the 0 is doing there but causes errors, and many such others.

[backspace]

heh well it wasn’t trivial to me, it’s been the major work of the past month.

There are a lot of problems within the CSS, as you’ve found. I can’t prioritise addressing them at the moment, sadly.

[the-j0k3r]

heh well it wasn’t trivial to me, it’s been the major work of the past month.

I meant the only conflict file is only two lines maybe even just one, The rebase operation should handle it automatically and if you use Atom its shouldn't make much noise if it does.

I didnt mean the work you did was trivial :D that trivial definitely is not sir, most certainly not.

Ill rebase this off of master anyway, thanks for your time sir.

[the-j0k3r]

@backspace there we go all done and rebased against master.

[backspace]

I ended up adding another commit in #1656 as the display: flex was a mistaken inclusion. Thanks for finding these!

[the-j0k3r]

Not very nice to remove my contribution in this manner.

[backspace]

I mentioned you in the squashed commit and linked to your PR, I don’t understand how that’s a removal. Do you have a recommendation on what I could have done differently?

My recommendation to you is to allow edits from maintainers, I wouldn’t have had to make my own PR that way.

[the-j0k3r]

I mentioned you in the squashed commit and linked to your PR

Not same thing according to how GitHub tracks contributions but... OK...

Do you have a recommendation on what I could have done differently?

Yes.

My recommendation to you is to allow edits from maintainers, I wouldn’t have had to make my own PR that way.

You could have asked or made a review/comment or something, that's what these issue thinga-me-bobs are for no?

👍

While we are here.. were are the repos for Travis Status and Travis.com, I found an inordinate amount of issues, typos similar to these, dozens of duplicate properties and lord knows what else.

[backspace]

Was your goal to get onto the contributor list on GitHub? If so, you could make an empty commit PR and I’ll merge it.

I have a limited amount of time to engage in this kind of work and I didn’t want to wait for your response.

[joshk]

@the-j0k3r your help and contributions are really appreciated. Thank you!