Recurse into submodules with git

[joliss]

It seems like a reasonable expectation to me that most project will need their submodules to run their test suites. (I just ran into this with Capybara, which requires an xpath submodule.)

I wasn't able to get the tests running (#4), so this is complete untested! Edit: Tested on Travis-CI -- it works. :)

[michaelklishin]

It kinda shows that this pull request was completely untested, but I merged it, so I fixed the issue before writing here. --recurse-submodules is a feature that stock version of git (1.7.0) in Ubuntu 10.04.2 does not support, so builds failed to run. We had to upgrade to 1.7.5.4.

[joliss]

Very cool, thanks for merging and fixing.

Any idea when it might be live on travis-ci.org? (Not to nag -- I'm just trying to get Capybara running on travis-ci.org, so I'm not in a hurry.)

[michaelklishin]

git 1.7.5.4 has landed just about an hour ago. We will see when we will upgrade workers, they need some testing.

[joliss]

Not to nag, but are there any plans for updating the workers soon?

I can't work around this by putting git submodule update --init into my before_script, because bundle install gets run before the before_script; see for instance http://travis-ci.org/#!/joliss/capybara/builds/58259

[ahx]

+1 for deploying this. I have the same problem.

[michaelklishin]

We will see what we can do in the next day or two.

[Burgestrand]

Any updates on this? I found myself needing it too. :)

[michaelklishin]

Can anybody give me a link to a repository that has this problem? I want to test it locally first.

[Burgestrand]

One of my own gems, Hallon, should break without this nowadays (see build).

Capybara also breaks without it, but I was told this issue is not the only reason for that.

[Burgestrand]

Anything happened with this issue? Perhaps opening it and adding a “not deployed yet” label to it would keep it from becoming forgotten? :)

[michaelklishin]

Recursion into submodules used to break the worker. It is not only not deployed, it is currently reverted. Now we have git 1.7.5 which should support --recurse-submodules but we did not try it yet.

[jnicklas]

Why not just add a git submodule update --init directly after the clone? Granted it won't recurse through submodules, but it should solve the problems of all of us on this issue, I think. I'd be happy to work up a patch.

Or, if we have this on the workers now, can we re-apply this patch and see if it works now?

[michaelklishin]

As mentioned in #22: I don't think there is any need for special support for submodules, before_install solves this and many other similar problems.