vsphere: fix incorrect PoweredOn conditional #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it returned true when the VM was _not_ powered on, which is the opposite of what we want. This caused the janitor to try to destroy all VMs that were powered on (but luckily it thought they were powered off, so it tried to destroy them without powering them off first, causing vSphere to error and the VMs were left alone).
Current coverage is 44.27% (diff: 0.00%)@@ master #5 diff @@
==========================================
Files 5 5
Lines 262 262
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 116 116
Misses 135 135
Partials 11 11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it returned true when the VM was not powered on, which is the opposite of what we want. This caused the janitor to try to destroy all VMs that were powered on (but luckily it thought they were powered off, so it tried to destroy them without powering them off first, causing vSphere to error and the VMs were left alone).