Fixes for some obvious FindBugs-discovered inefficiencies

travisennis · Nov 13, 2008 · 82429c9 · 82429c9
1 parent c0b354f
commit 82429c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/org/mozilla/javascript/NativeArray.java b/src/org/mozilla/javascript/NativeArray.java
@@ -1521,7 +1521,7 @@ else if (start < 0)
                       if (na.dense[i] != Scriptable.NOT_FOUND &&
                           ScriptRuntime.shallowEq(na.dense[i], compareTo))
                       {
-                          return new Long(i);
+                          return Long.valueOf(i);
                       }
                   }
                 }

diff --git a/src/org/mozilla/javascript/NativeError.java b/src/org/mozilla/javascript/NativeError.java
@@ -90,7 +90,7 @@ static NativeError make(Context cx, Scriptable scope,
             int[] linep = new int[1];
             String fileName = Context.getSourcePositionFromStack(linep);
             ScriptableObject.putProperty(obj, "lineNumber", 
-                    new Integer(linep[0]));
+                    Integer.valueOf(linep[0]));
             if(arglen < 2) {
                 ScriptableObject.putProperty(obj, "fileName", fileName);
             }