Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #65 #66

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Fixes #65 #66

merged 3 commits into from
Nov 15, 2021

Conversation

fernyb
Copy link
Contributor

@fernyb fernyb commented Oct 17, 2021

The TeamCity service messages documentation say "testIgnored" message can be reported without the matching "testStarted" and "testFinished" messages.

Reference:
https://www.jetbrains.com/help/teamcity/service-messages.html#Nested+test+reporting

Proposed changes

Will produce the correct output for TeamCity by not including the "testFinished" or "testStarted".
It will also resolve bug #65

Types of changes

What types of changes does your code introduce
Put an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ x ] Lint and unit tests pass locally with my changes
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

…print testStarted when test is ignored as they are not required when test is ignored.
@jamie-sherriff
Copy link
Collaborator

Thanks @fernyb for this, sorry for the delay in getting to it.

My only question is that these changes change the default reporter output with no ability to revert the behavior.

I agree it makes sense but what if people are relying on pending tests being marked as passed?

Can you add a control option to this and have it default to on so people the option of disabling the functionality?

@fernyb
Copy link
Contributor Author

fernyb commented Nov 6, 2021

@jamie-sherriff I've updated to use an option to turn on this feature.

@jamie-sherriff
Copy link
Collaborator

@fernyb Thanks for that, I will release a new minor version in the coming days.

@jamie-sherriff jamie-sherriff merged commit fef7be0 into travisjeffery:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants