Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-sass is deprecated #1748

Closed
seiyab opened this issue Jun 15, 2022 · 6 comments
Closed

node-sass is deprecated #1748

seiyab opened this issue Jun 15, 2022 · 6 comments

Comments

@seiyab
Copy link
Contributor

seiyab commented Jun 15, 2022

Moving onto dart-sass is recommended.
https://sass-lang.com/blog/libsass-is-deprecated

Major drawbacks of node-sass:
@seiyab
Copy link
Contributor Author

seiyab commented Jun 15, 2022 •
edited
Loading

Oh I found node-sass might be no longer used.

@seiyab
Copy link
Contributor Author

seiyab commented Jun 15, 2022

This is the commit first node-sass is added.
72fd25f

@seiyab
Copy link
Contributor Author

seiyab commented Jun 15, 2022

node-sass is indirectly used.
bootstrap-loader uses sass-loader.

@yoyama
Copy link
Contributor

yoyama commented Jul 6, 2022

We may need upgrade many libraries and Node.js version.
We welcome your contribution 🙂

@seiyab
Copy link
Contributor Author

seiyab commented Jul 6, 2022 •
edited
Loading

Thank you for your comment.
I found migration into Dart Sass is not straightforward.
bootstrap-loader requires node-sass as a peer dependency.
https://github.com/shakacode/bootstrap-loader/blob/2c4c85b86313da033a2104e84895ec87285ad4b5/package.json#L41
So just removing node-sass from digdag-ui dev dependencies doesn't work.
Though I think removing bootstrap-loader will be good decision in the long run, it might be hard.
I might give up if I cannot come up with a good idea .

seiyab added a commit to seiyab/digdag that referenced this issue Jul 13, 2022
@seiyab
LibSass -> Dart Sass
d95d580 
- node-sass -> sass
- remove webpack-loader

Issue: treasure-data#1748
@seiyab seiyab mentioned this issue Jul 13, 2022
Merged
yoyama pushed a commit that referenced this issue Jul 26, 2022
@seiyab
LibSass -> Dart Sass (#1757)
737fc77 
* LibSass -> Dart Sass
- node-sass -> sass
- remove webpack-loader
Issue: #1748 
* mock bootstrap scss
@seiyab
Copy link
Contributor Author

seiyab commented Jul 26, 2022

#1757 Done.

@seiyab seiyab closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoyama @seiyab