Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibSass -> Dart Sass #1757

Merged
merged 2 commits into from
Jul 26, 2022
Merged

LibSass -> Dart Sass #1757

merged 2 commits into from
Jul 26, 2022

Conversation

seiyab
Copy link
Contributor

@seiyab seiyab commented Jul 13, 2022

Issue: #1748

  • node-sass -> sass
  • remove webpack-loader

I followed this doc: https://getbootstrap.com/docs/4.0/getting-started/webpack/

I checked behavior of workflows page, projects page, session page and so on with example workflows.
But I'm not sure enough whether it fully works or not yet.

- node-sass -> sass
- remove webpack-loader

Issue: treasure-data#1748
@seiyab seiyab marked this pull request as ready for review July 14, 2022 13:07
@yoyama yoyama self-requested a review July 26, 2022 01:58
Copy link
Contributor

@yoyama yoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I also build and confirm the behavior of UI and no found any issues.

@yoyama yoyama merged commit 737fc77 into treasure-data:master Jul 26, 2022
@seiyab seiyab deleted the 1748-dart-sass branch July 26, 2022 05:21
@seiyab seiyab mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants