Change temp file prefix used by BufferedRemoteTaskLogger #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muga
changed the title
muga
changed the title
muga
force-pushed
the
fix_s3_log_server_temp_file
branch
from
bf69f61
to
df643a5
Compare
muga
changed the title
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that
BufferedRemoteTaskLoggercannot upload log files on S3 correctly. TheBufferedRemoteTaskLoggerwrites logs tmp files first before uploading them on S3. The tmp file prefix uses task name, if task name is too long, it cannot create tmp files.In this PR, the prefix is changed with combination with projectId, workflowName and sessionTime. sessionTime is formatted by ISO-8601 and used as string.
Reported on #729 and assumes #751.