-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support API v3 #13
Merged
Merged
Support API v3 #13
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
84b044f
[support_api_v3] Convert to java using embulk-base-restclient
thangnc b66720c
[support_api_v3] Added class using OAuth2
thangnc 0e2abae
[support_api_v3] Enable test with CI
thangnc 99a5273
[support_api_v3] Added auth type
thangnc 8294640
[support_api_v3] Added validation and update test
thangnc 67131a0
[support_api_v3] Upgraded library and updated testcase
thangnc f8c3623
[support_api_v3] Updated travis with gradle
thangnc 148e11d
[support_api_v3] Refactor with abstract recordbuffer
thangnc 5920127
[support_api_v3] Refactor with handling response error from API
thangnc 3644537
[support_api_v3] Updated unit test
thangnc 7815275
[support_api_v3] Fixed unit test
thangnc 52b6de3
[support_api_v3] Enabled browse category ids from name
thangnc a1ec43d
[support_api_v3] Fixed unit test and added mock
thangnc 1215df4
[support_api_v3] Updated unit test
thangnc 483c478
[support_api_v3] Updated README and fix NPE
thangnc 96206a6
[support_api_v3] Released minor 0.3.0.1
thangnc f4eec5f
[support_api_v3] Fixed PR and added test case
thangnc 3839808
[support_api_v3] Fixed checkstyle
thangnc 04f5d35
[support_api_v3] Updated get data center and added test case
thangnc 30b2d2c
[support_api_v3] Fixed problem update interest categories
thangnc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
service_name: travis-ci | ||
service_name: travis-ci |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,13 @@ | ||
*~ | ||
/pkg/ | ||
/tmp/ | ||
/.bundle/ | ||
/Gemfile.lock | ||
/coverage/ | ||
*.gemspec | ||
.gradle/ | ||
/classpath/ | ||
build/ | ||
.idea | ||
/.settings/ | ||
/.metadata/ | ||
.classpath | ||
.project | ||
bin/ |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,5 @@ | ||
language: jruby | ||
before_install: | ||
- rvm get head --auto-dotfiles | ||
- rvm install jruby-9.0.1.0 | ||
- gem install bundler --version 1.10.6 | ||
- bundle install | ||
language: java | ||
jdk: | ||
- openjdk7 | ||
script: | ||
- bundle exec rake cov | ||
- ./gradlew clean checkstyle check jacocoTestReport |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,124 @@ | ||
plugins { | ||
id "com.jfrog.bintray" version "1.7.3" | ||
id "com.github.jruby-gradle.base" version "0.1.5" | ||
id "java" | ||
id "checkstyle" | ||
id "jacoco" | ||
} | ||
import com.github.jrubygradle.JRubyExec | ||
repositories { | ||
mavenCentral() | ||
jcenter() | ||
// TODO(dmikurube): Remove this after embulk-base-restclient goes to jcenter. | ||
maven { | ||
url "https://dl.bintray.com/embulk-base-restclient/maven" | ||
} | ||
} | ||
configurations { | ||
provided | ||
} | ||
|
||
version = "0.3.0.1" | ||
|
||
sourceCompatibility = 1.7 | ||
targetCompatibility = 1.7 | ||
|
||
dependencies { | ||
compile "org.embulk:embulk-core:0.8.15" | ||
provided "org.embulk:embulk-core:0.8.15" | ||
compile "org.embulk.base.restclient:embulk-base-restclient:0.5.0" | ||
compile "org.embulk.base.restclient:embulk-util-retryhelper-jetty92:0.5.0" | ||
// compile "YOUR_JAR_DEPENDENCY_GROUP:YOUR_JAR_DEPENDENCY_MODULE:YOUR_JAR_DEPENDENCY_VERSION" | ||
|
||
testCompile "junit:junit:4.+" | ||
testCompile "org.embulk:embulk-core:0.8.15:tests" | ||
testCompile "org.embulk:embulk-test:0.8.15" | ||
testCompile "org.embulk:embulk-standards:0.8.15" | ||
testCompile "org.mockito:mockito-core:2.+" | ||
} | ||
|
||
test { | ||
jvmArgs "-XX:MaxPermSize=128M" | ||
// Set the timezone for testing somewhere other than my machine to increase the chances of catching timezone bugs | ||
systemProperty 'user.timezone', 'PST' | ||
testLogging { | ||
events "passed", "skipped", "failed" | ||
} | ||
} | ||
|
||
task classpath(type: Copy, dependsOn: ["jar"]) { | ||
doFirst { file("classpath").deleteDir() } | ||
from (configurations.runtime - configurations.provided + files(jar.archivePath)) | ||
into "classpath" | ||
} | ||
clean { delete "classpath" } | ||
|
||
checkstyle { | ||
configFile = file("${project.rootDir}/config/checkstyle/checkstyle.xml") | ||
toolVersion = '6.14.1' | ||
} | ||
checkstyleMain { | ||
configFile = file("${project.rootDir}/config/checkstyle/default.xml") | ||
ignoreFailures = true | ||
} | ||
checkstyleTest { | ||
configFile = file("${project.rootDir}/config/checkstyle/default.xml") | ||
ignoreFailures = true | ||
} | ||
task checkstyle(type: Checkstyle) { | ||
classpath = sourceSets.main.output + sourceSets.test.output | ||
source = sourceSets.main.allJava + sourceSets.test.allJava | ||
} | ||
|
||
task gem(type: JRubyExec, dependsOn: ["gemspec", "classpath"]) { | ||
jrubyArgs "-rrubygems/gem_runner", "-eGem::GemRunner.new.run(ARGV)", "build" | ||
script "${project.name}.gemspec" | ||
doLast { ant.move(file: "${project.name}-${project.version}.gem", todir: "pkg") } | ||
} | ||
|
||
task gemPush(type: JRubyExec, dependsOn: ["gem"]) { | ||
jrubyArgs "-rrubygems/gem_runner", "-eGem::GemRunner.new.run(ARGV)", "push" | ||
script "pkg/${project.name}-${project.version}.gem" | ||
} | ||
|
||
task "package"(dependsOn: ["gemspec", "classpath"]) << { | ||
println "> Build succeeded." | ||
println "> You can run embulk with '-L ${file(".").absolutePath}' argument." | ||
} | ||
|
||
jacocoTestReport { | ||
group = "Reporting" | ||
reports { | ||
xml.enabled false | ||
csv.enabled false | ||
html.destination "${buildDir}/reports/coverage" | ||
} | ||
} | ||
|
||
task gemspec { | ||
ext.gemspecFile = file("${project.name}.gemspec") | ||
inputs.file "build.gradle" | ||
outputs.file gemspecFile | ||
doLast { gemspecFile.write($/ | ||
Gem::Specification.new do |spec| | ||
spec.name = "${project.name}" | ||
spec.version = "${project.version}" | ||
spec.authors = "Thang Nguyen" | ||
spec.summary = %[Mailchimp output plugin for Embulk] | ||
spec.description = %[Dumps records to MailChimp.] | ||
spec.email = ["thang@treasure-data.com"] | ||
spec.licenses = ["Apache-2.0"] | ||
spec.homepage = "https://github.com/treasure-data/embulk-output-mailchimp" | ||
|
||
spec.files = `git ls-files`.split("\n") + Dir["classpath/*.jar"] | ||
spec.test_files = spec.files.grep(%r"^(test|spec)/") | ||
spec.require_paths = ["lib"] | ||
|
||
#spec.add_dependency 'YOUR_GEM_DEPENDENCY', ['~> YOUR_GEM_DEPENDENCY_VERSION'] | ||
spec.add_development_dependency 'bundler', ['~> 1.0'] | ||
spec.add_development_dependency 'rake', ['>= 10.0'] | ||
end | ||
/$) | ||
} | ||
} | ||
clean { delete "${project.name}.gemspec" } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
type: mailchimp | ||
auth_method: api_key | ||
apikey: xxxxxxxxxxxxxxxxxxx | ||
access_token: xxxxxxxxxxxxxxxxxxx | ||
list_id: xxxxxxxxxxxxxxxxxxx |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
machine: | ||
java: | ||
version: openjdk7 | ||
environment: | ||
TERM: "dumb" | ||
EMBULK_OUTPUT_MAILCHIMP_TEST_CONFIG: "${HOME}/${TRAVIS_BUILD_DIR}/ci/travis_mailchimp.yml" | ||
|
||
test: | ||
override: | ||
- ./gradlew clean checkstyle check jacocoTestReport | ||
post: | ||
- cp -R build/reports/* $CIRCLE_ARTIFACTS | ||
|
||
notify: | ||
webhooks: | ||
- url: https://td-beda.herokuapp.com/circleci_callback |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok to use vx.x.x style versioning.
Something special reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sakama We wanted to release a "snapshot" version before PR is merged so that we can test on console-development, hence used an additional number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense.