-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.2 and Windows CI tests #55
Conversation
tung-vu-td
commented
Jul 19, 2023
- Adding CI tests for Ruby 3.2
- Adding CI tests for Windows
- Remove Gemfile.lock due to different gems of Linux and Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for adding Ruby 3.2 and Windows tests! Do we also use GitHub actions for Windows test? (a6fe575) |
@daipom Yes, I added the windows tests for Github actions (based on your PR) as well on top of CircleCI window test to cover different versions of Ruby. Looks like it simplifies a lot compare to CircleCI for testing on windows. I still need to keep CircleCI tests for linux and deployment as well, at least for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for data exfiltrations
I see! Thanks for the explanation! |
@daipom Huge thanks for helping us with these tests. Regarding support for 3.2. Since we don't add any new code, I assume you can use the latest version (1.2.1) without any issue? Or am I missing something and still need to release new version? |
Thanks so much! Thanks for adding tests! |