Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.2 and Windows CI tests #55

Merged
merged 9 commits into from
Jul 20, 2023
Merged

Add Ruby 3.2 and Windows CI tests #55

merged 9 commits into from
Jul 20, 2023

Conversation

tung-vu-td
Copy link
Contributor

  • Adding CI tests for Ruby 3.2
  • Adding CI tests for Windows
  • Remove Gemfile.lock due to different gems of Linux and Windows

Copy link

@kietdo360 kietdo360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daipom
Copy link
Contributor

daipom commented Jul 19, 2023

Thanks for adding Ruby 3.2 and Windows tests!

Do we also use GitHub actions for Windows test? (a6fe575)

@kietdo360 kietdo360 requested a review from a team July 19, 2023 05:52
@tung-vu-td
Copy link
Contributor Author

tung-vu-td commented Jul 19, 2023

@daipom Yes, I added the windows tests for Github actions (based on your PR) as well on top of CircleCI window test to cover different versions of Ruby. Looks like it simplifies a lot compare to CircleCI for testing on windows. I still need to keep CircleCI tests for linux and deployment as well, at least for now

Copy link

@nmpennypacker nmpennypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations

@daipom
Copy link
Contributor

daipom commented Jul 19, 2023

@daipom Yes, I added the windows tests for Github actions (based on your PR) as well on top of CircleCI window test to cover different versions of Ruby. Looks like it simplifies a lot compare to CircleCI for testing on windows. I still need to keep CircleCI tests for linux and deployment as well, at least for now

I see! Thanks for the explanation!

@tung-vu-td
Copy link
Contributor Author

@daipom Huge thanks for helping us with these tests.

Regarding support for 3.2. Since we don't add any new code, I assume you can use the latest version (1.2.1) without any issue? Or am I missing something and still need to release new version?

@daipom
Copy link
Contributor

daipom commented Jul 19, 2023

Thanks so much!
I was checking each embedded plugin of td-agent since the next package will embed Ruby 3.2.
I think it is ok since the test is successful with Ruby 3.2!

Thanks for adding tests!

@tung-vu-td tung-vu-td merged commit ef87034 into master Jul 20, 2023
10 checks passed
@tung-vu-td tung-vu-td deleted the support-ruby-32 branch July 20, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants