Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPP-3183: Support JDK 11 #17

Merged
merged 2 commits into from Oct 6, 2020
Merged

MPP-3183: Support JDK 11 #17

merged 2 commits into from Oct 6, 2020

Conversation

yuokada
Copy link

@yuokada yuokada commented May 20, 2020 •
edited

@yuokada
Copy link
Author

yuokada commented May 20, 2020 •
edited 

~/I/base-presto ❯❯❯ ./mvnw install -DskipTests
<!-- Cut a progress -->
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (default) @ presto-main ---
[INFO] Ignoring requireUpperBoundDeps in org.codehaus.plexus:plexus-utils
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for javax.annotation:javax.annotation-api:1.3.1 paths to dependency are:
+-io.prestosql:presto-main:317
  +-javax.annotation:javax.annotation-api:1.3.1
and
+-io.prestosql:presto-main:317
  +-io.airlift:bootstrap:0.183.1
    +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.2
and
+-io.prestosql:presto-main:317
  +-io.airlift:discovery:0.183.1
    +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.3.2
and
+-io.prestosql:presto-main:317
  +-io.airlift:http-server:0.183.1
    +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.3.2
and
+-io.prestosql:presto-main:317
  +-io.airlift.discovery:discovery-server:1.29
    +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.2
and
+-io.prestosql:presto-main:317
  +-io.airlift:http-client:0.183.1
    +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.3.2
and
+-io.prestosql:presto-main:317
  +-io.airlift:jaxrs:0.183.1
    +-org.glassfish.jersey.core:jersey-common:2.26
      +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.2
and
+-io.prestosql:presto-main:317
  +-io.airlift:jaxrs:0.183.1
    +-org.glassfish.jersey.core:jersey-server:2.26
      +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.2
and
+-io.prestosql:presto-main:317
  +-io.airlift:jaxrs:0.183.1
    +-org.glassfish.jersey.inject:jersey-hk2:2.26
      +-org.glassfish.hk2:hk2-locator:2.5.0-b42
        +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.2
and
+-io.prestosql:presto-main:317
  +-io.airlift:jaxrs:0.183.1
    +-org.glassfish.jersey.inject:jersey-hk2:2.26
      +-org.glassfish.hk2:hk2-locator:2.5.0-b42
        +-org.glassfish.hk2:hk2-utils:2.5.0-b42
          +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.2
]

These 3 dependencies are problematic.

and
+-io.prestosql:presto-main:317
  +-io.airlift:discovery:0.183.1
    +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.3.2
and
+-io.prestosql:presto-main:317
  +-io.airlift:http-server:0.183.1
    +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.3.2

and
+-io.prestosql:presto-main:317
  +-io.airlift:http-client:0.183.1
    +-javax.annotation:javax.annotation-api:1.3.1 (managed) <-- javax.annotation:javax.annotation-api:1.3.2

@yuokada
Copy link
Author

yuokada commented May 20, 2020

I downgraded javax.annotation-api to 1.3.1 and published 0.183.2.
treasure-data/airlift@8fca104

@yuokada
Copy link
Author

yuokada commented May 20, 2020 

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for io.airlift:log-manager:0.183 paths to dependency are:
+-io.prestosql:presto-phoenix:317
  +-io.airlift:bootstrap:0.183.2
    +-io.airlift:log-manager:0.183
and
+-io.prestosql:presto-phoenix:317
  +-io.prestosql:presto-main:317
    +-io.airlift:log-manager:0.183.2
and
+-io.prestosql:presto-phoenix:317
  +-io.prestosql:presto-tests:317
    +-io.airlift:log-manager:0.183.2
and
+-io.prestosql:presto-phoenix:317
  +-io.prestosql:presto-tests:317
    +-io.prestosql:presto-main:317
      +-io.airlift:log-manager:0.183.2
]

xerial
xerial reviewed May 20, 2020
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@yuokada yuokada changed the title [DO NOT MERGE] Add configuration for repositories [DO NOT MERGE] Support JDK 11 May 21, 2020
@yuokada yuokada changed the title [DO NOT MERGE] Support JDK 11 [DO NOT MERGE] MPP-3183: Support JDK 11 May 22, 2020
@yuokada
Copy link
Author

yuokada commented May 28, 2020 •
edited 

May 28 07:54:42 ip-172-23-150-6 presto[30179]: + exec start-stop-daemon --start --chuid presto:presto --exec /opt/presto/bin/launcher.py -- run
May 28 07:54:42 ip-172-23-150-6 presto[30179]: OpenJDK 64-Bit Server VM warning: Option AggressiveOpts was deprecated in version 11.0 and will likely be removed in a future release.
May 28 07:54:42 ip-172-23-150-6 presto[30179]: Presto requires amd64 or ppc64le on Linux (found aarch64)

Need to backport this commit.
trinodb#2809

@yuokada
Copy link
Author

yuokada commented Sep 16, 2020 •
edited

Rebased from hotfix-317 branch after a long time.

@yuokada
Upgrade airlift-packaging to 0.183.5 & Add configuration for pluginRe…
b8a481b 
…positories

Add configuration for repositories

Upgrade airlift to 0.183.3

save

Update dep.packaging.version value to 0.183

Update airlift to 0.183.4

Update airlift to 0.183.5

Upgrade airlift-packaging to 0.183.5
@yuokada
Allow running Presto on Linux aarch64
19512d6
yuokada
yuokada commented Sep 16, 2020
View reviewed changes
pom.xml
@@ -44,7 +44,7 @@
<air.maven.version>3.3.9</air.maven.version>

<dep.antlr.version>4.7.1</dep.antlr.version>
<dep.airlift.version>0.183</dep.airlift.version>
<dep.airlift.version>0.183.5</dep.airlift.version>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.183.5 is managed here.
https://github.com/treasure-data/airlift/commits/0.183.1-for-td

@yuokada yuokada changed the title [DO NOT MERGE] MPP-3183: Support JDK 11 MPP-3183: Support JDK 11 Sep 16, 2020
@yuokada
Copy link
Author

yuokada commented Sep 16, 2020 •
edited

I'm feeling like to merge this into hotfix-317 branch around at when we completed plazma metadata api migration.

@yuokada
Copy link
Author

yuokada commented Oct 6, 2020

This PR has been approved. I will merge.
https://treasure-data.slack.com/archives/G01242EDF2N/p1601965952072700?thread_ts=1601959087.070900&cid=G01242EDF2N

@yuokada yuokada merged commit 8e19a56 into hotfix-317 Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xerial xerial xerial left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yuokada @xerial