Deprecate Guava Multimap and Function in favor of JDK & Remove Guava collections #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exoego
force-pushed
the
135-no-guava-collection
branch
2 times, most recently
from
e7a307e
to
92a3dc3
Compare
exoego
changed the title
|
I've searched our internal repo and found a lot of setHeader(Multimap) usage. So 2 looks better. |
exoego
force-pushed
the
135-no-guava-collection
branch
from
40d7eef
to
56ae642
Compare
exoego
added
chore
exoego
changed the title
exoego
force-pushed
the
135-no-guava-collection
branch
from
74ca255
to
b31fe3a
Compare
exoego
force-pushed
the
135-no-guava-collection
branch
from
b31fe3a
to
a10823c
Compare
exoego
changed the title
|
Thanks. I'll take a look |
xerial
reviewed
Feb 27, 2023
| return builder.build(); | ||
| } | ||
|
|
||
| public Map<String, Collection<String>> getHeaderParamsV2() |
There was a problem hiding this comment.
This will be the default method after deprecating getHeaderParams(). How about using a more regular method name like getAllHeaders() but a different name from getHeaderParams()?
|
ok. Basically LGTM. @exoego Only one suggestion to use a normal method name without any version suffix https://github.com/treasure-data/td-client-java/pull/217/files#r1119311242 |
xerial
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #135
This is the final Guava deprecation and removal.
After this PR and a new minor version cut, I think we could delete the deprecated one and guava dependency.
The problem is
Multimap<K, V>. How should we remove it?Possible directions:
Map<K, Collection<V>>and introduce breaking change aggressively.Map<K, Col<V>>and deprecate the old methods withMuiltimap.TDClientConfig#headersandTDApiRequest#getHeaderParams(). See new members~V2.I propose picking 2nd since it helps users to migrate.
WDYT?