Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Guava net module with JDK equivalents #225

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Replace Guava net module with JDK equivalents #225

merged 7 commits into from
Jan 31, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jan 26, 2023 •
edited

Part of #135

  • HTTP Header constants are all inlined.
  • UrlPathSegmentEscaper class is added. This class is compatible with com.google.common.net.UrlEscapers.urlPathSegmentEscaper.

@exoego exoego marked this pull request as ready for review January 26, 2023 07:26
@exoego exoego added the dependencies Pull requests that update a dependency file label Jan 26, 2023
@exoego exoego force-pushed the guava-net branch 2 times, most recently from 8f95b52 to 8fabc75 Compare January 27, 2023 09:14
@exoego exoego added chore internal changes (not user-facing) and removed dependencies Pull requests that update a dependency file labels Jan 28, 2023
yuokada
yuokada approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@yuokada yuokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exoego exoego merged commit f267ae5 into master Jan 31, 2023
@exoego exoego deleted the guava-net branch January 31, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuokada yuokada yuokada approved these changes

Assignees
No one assigned
Labels
chore internal changes (not user-facing)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@exoego @yuokada