Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JSON.simple with already-inuse Jackson #244

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Replace JSON.simple with already-inuse Jackson #244

merged 2 commits into from
Feb 1, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jan 31, 2023 •
edited

No reason to use two different JSON library?

@exoego exoego changed the title Replace JSON.simple with Jackson Replace JSON.simple with already-used Jackson Jan 31, 2023
@exoego exoego changed the title Replace JSON.simple with already-used Jackson Replace JSON.simple with already-inuseJackson Jan 31, 2023
@exoego exoego changed the title Replace JSON.simple with already-inuseJackson Replace JSON.simple with already-inuse Jackson Jan 31, 2023
@exoego exoego marked this pull request as ready for review January 31, 2023 14:32
@yuokada yuokada added the dependencies Pull requests that update a dependency file label Feb 1, 2023
xerial
xerial approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@xerial xerial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The next removal target will be Jackson but as long as no interface using Jackson is exposed, we can shade its usage :)

@xerial xerial merged commit 685f050 into master Feb 1, 2023
@xerial xerial deleted the remove-jsonsimple branch February 1, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xerial xerial xerial approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exoego @xerial @yuokada