Support td query --domain-key=KEY
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurse
force-pushed
the
support-domain-key
branch
3 times, most recently
from
932cb6f
to
7a51b72
Compare
nurse
force-pushed
the
support-domain-key
branch
from
0355104
to
d017c27
Compare
"Domain key" is an optional user-provided unique ID. Users can include this ID with your `create` request to ensure idempotence.
nurse
force-pushed
the
support-domain-key
branch
from
d017c27
to
7b48177
Compare
| require 'td/command/list' | ||
| require 'td/command/query' | ||
| require 'td/client' | ||
| require 'tempfile' |
There was a problem hiding this comment.
These requires are necessary? (cosme)
There was a problem hiding this comment.
With these requires, I can run only this spec like bundle exec rake spec SPEC_OPTS="-fd" SPEC=spec/td/command/query_spec.rb.
|
Commented minor but LGTM to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Domain key" is an optional user-provided unique ID.
Users can include this ID with your
createrequest to ensure idempotence.