Bump faraday version from 0.12 to 1.0 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently failing: Looks like |
pedrombl
force-pushed
the
update-faraday
branch
from
4c5f644
to
8ef196e
Compare
pedrombl
commented
Oct 12, 2021
pedrombl
force-pushed
the
update-faraday
branch
from
8ef196e
to
cd7864f
Compare
|
@Lewuathe thanks for releasing tiny-presto. Now this is ready to be reviewed too! :) |
jclarkin
approved these changes
Nov 22, 2021
takezoe
approved these changes
Nov 25, 2021
|
Anyway, let me merge this and will see how CI works on master. Thanks for your contribution! |
composerinteralia
added a commit
to composerinteralia/trino-client-ruby
that referenced
this pull request
Jun 4, 2024
Trino 1.0.2 includes some Faraday compatibility changes: treasure-data#73 treasure-data#75 But neither of those changes make the gem incompatible with Faraday 0.6.6. This commit relaxes the version so we can upgrade Presto and Faraday independently. Once we are on Faraday 1.x we can go back to the official release of this gem.
composerinteralia
added a commit
to composerinteralia/trino-client-ruby
that referenced
this pull request
Jun 4, 2024
This commit applies the change from treasure-data#73 This will allow us to upgrade presto-client separately from upgrading Faraday. Once we are on Faraday v1.0 we can upgrade directly to trino-client v1.0.2 without issue.
composerinteralia
added a commit
to composerinteralia/trino-client-ruby
that referenced
this pull request
Jun 4, 2024
This commit applies the change from treasure-data#73 This will allow us to upgrade presto-client separately from upgrading Faraday. Once we are on Faraday v1.0 we can upgrade directly to trino-client v1.0.2 without issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
resolves: #65
Currently the gem trino-client depends on Faraday 0.12. If a project uses the lastest version of Faraday (1.7) and introduces trino-client, it needs to have the Faraday gem downgraded.
Overview
Checklist
Created tests which fail without the change (if possible)Extended the README / documentation, if necessary