Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce standard to check coding style #78

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Introduce standard to check coding style #78

merged 2 commits into from
Nov 25, 2022

Conversation

yuokada
Copy link
Contributor

@yuokada yuokada commented Nov 14, 2022 •
edited

Purpose

Introduce coding rule

Overview

  • Introduce standard and a job to check coding style using it in github actions
  • Fix coding style

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@yuokada yuokada marked this pull request as ready for review November 22, 2022 00:43
@yuokada yuokada requested a review from a team as a code owner November 22, 2022 00:43
@yuokada yuokada requested a review from takezoe November 22, 2022 15:40
takezoe
takezoe approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@takezoe takezoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yuokada yuokada merged commit bed70c9 into master Nov 25, 2022
@yuokada yuokada deleted the standardrb branch November 25, 2022 04:20
@exoego exoego added the chore non user-facing trivial stuff (CI, refactoring, etc) label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takezoe takezoe takezoe approved these changes

Assignees
No one assigned
Labels
chore non user-facing trivial stuff (CI, refactoring, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuokada @takezoe @exoego