Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow supertype nodes as identifiers #33

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

clason
Copy link
Contributor

@clason clason commented May 6, 2024

Add / to valid IDENTIFIER to support foo/bar supertype nodes in
queries, e.g., for Haskell. Followup could add dedicated support for
such nodes (if there is a use case).

Closes #29.

@lucario387

Add `/` to valid `IDENTIFIER` to support `foo/bar` supertype nodes in
queries, e.g., for Haskell. Followup could add dedicated support for
such nodes (if there is a use case).
@clason clason merged commit 0c0ed8e into master May 6, 2024
3 checks passed
@clason clason deleted the fix/supertype branch May 6, 2024 11:43
@lucario387
Copy link

OOps.

(foo/bar
  (baz)
  (bez))

creates a tree like

(program ; [0, 0] - [15, 0]
  (list ; [0, 0] - [2, 8]
    (symbol) ; [0, 1] - [0, 8]
    (list ; [1, 2] - [1, 7]
      (symbol)) ; [1, 3] - [1, 6]
    (list ; [2, 2] - [2, 7]
      (symbol)))) ; [2, 3] - [2, 6]

@clason
Copy link
Contributor Author

clason commented May 6, 2024

Does #34 work better? Then I'll merge that despite the state increase.

@lucario387
Copy link

Yes, it now does work with the formatter more often.

@lucario387
Copy link

tbf, both this and #34 does work. But somehow nvim/format-queries.lua somehow doesn't like this as much as #34

@clason
Copy link
Contributor Author

clason commented May 6, 2024

Okie, let's go with #34 then. The indeterminacy is bad, though, and should be looked at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: recorgnize super-type/concrete type syntax
3 participants